tags 639545 + fixed-upstream
forwarded 639545 https://labs.riseup.net/code/issues/3001
thanks
Hi Chris, hi rhatto,
Chris Lamb wrote (28 Aug 2011 00:11:36 GMT) :
> The rsync helper calls all rsync options as one *argv argument, like
> so:
> execve("/usr/bin/nice", ["nice", "-n", "0", "/usr/bin/rsync", "-av
> --delete --recursive --numer"..., "--exclude=/var/bkah"...,
> The rdiff helper uses "sh -c" to expand this, so we can probably
> consider that safe enough.
> Patch attached.
> - $nice $rsync "${rsync_options[@]}" $filelist_flag $excludes $batch_option
> $orig $dest_path | tee -a $log
> + $nice sh -c "$rsync ${rsync_options[@]} $filelist_flag $excludes
> $batch_option $orig $dest_path" | tee -a $log
It seems to me this bug is the same as one that was fixed in upstream
Git by commit 3ae23a. Both of you, feel free to confirm or correct me.
Bye,
--
intrigeri <intrig...@boum.org>
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
| Who wants a world in which the guarantee that we shall not
| die of starvation would entail the risk of dying of boredom ?
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
