forwarded 546667 ayttm-de...@lists.sourceforge.net
thanks

Hi Siddhesh,

Please check and adopt attached patch. I am adding it tonight..

Thanks to Dann for reporting this and patch!


---------- Forwarded message ----------
From: dann frazier <da...@debian.org>
Date: Tue, Sep 15, 2009 at 3:36 AM
Subject: Bug#546667: ayttm: gtkut_stock_button_new_with_label
implicitly converted to pointer
To: sub...@bugs.debian.org


Package: ayttm
Version: 0.6.0-1
Severity: serious
Tags: patch
Usertags: implicit-pointer-conversion

Our automated buildd log filter[1] detected a problem that is likely to
cause your package to segfault on architectures where the size of a
pointer is greater than the size of an integer, such as ia64 and amd64.

 Function `gtkut_stock_button_new_with_label' implicitly converted to
pointer at trigger.c:390

This is often due to a missing function prototype definition.
For more information, see [2].

Though it is guaranteed that this codepath will cause a segfault on certain
architectures, it is not guaranteed that this codepath would ever be executed
(e.g., if the returned pointer is never dereferenced). However, this bug
does prevent the ia64 buildd from successfully building this package, resulting
in a practical FTBFS issue and warranting the serious severity.

[1] http://people.debian.org/~dannf/check-implicit-pointer-functions
[2] http://wiki.debian.org/ImplicitPointerConversions



-- 
 Cheers,
 Kartik Mistry | 0xD1028C8D | IRC: kart_
 Debian GNU/Linux Developer | Identica: @kartikm
 Blogs: {ftbfs, kartikm}.wordpress.com
--- ayttm-0.6.0.orig/src/trigger.c	2009-09-06 21:49:25.000000000 -0600
+++ ayttm-0.6.0/src/trigger.c	2009-09-14 16:05:56.566011839 -0600
@@ -36,6 +36,7 @@
 #include "globals.h"
 #include "file_select.h"
 #include "messages.h"
+#include "gtk/gtkutils.h"
 
 
 static gint window_open = 0;

Reply via email to