On Wed, Nov 28, 2012 at 03:27:16 +0000, Stuart Prescott wrote:

> Package: lastfmproxy
> Version: 1.3b-2
> Severity: serious
> Justification: policy §9.1 (FHS: /var/lib is for state information not 
> scripts), python policy §2.1 (module placement)
> 
> Hi!
> 
> lastfmproxy ships a number of files in /var/lib that belong in /usr/share --
> this includes python module files and probably also the png/html/css/js files
> as well.
> 
I don't think this warrants serious severity.

> lastfmproxy: /var/lib/lastfmproxy/audioscrobbler.py
> lastfmproxy: /var/lib/lastfmproxy/changestation.py
> lastfmproxy: /var/lib/lastfmproxy/config.py
> lastfmproxy: /var/lib/lastfmproxy/data/album.png
> lastfmproxy: /var/lib/lastfmproxy/data/artist.png
> lastfmproxy: /var/lib/lastfmproxy/data/default.css
> lastfmproxy: /var/lib/lastfmproxy/data/default.html
> lastfmproxy: /var/lib/lastfmproxy/data/favicon.ico
> lastfmproxy: /var/lib/lastfmproxy/data/main.js
> lastfmproxy: /var/lib/lastfmproxy/data/nice_favicon.png
> lastfmproxy: /var/lib/lastfmproxy/data/noalbum_medium.gif
> lastfmproxy: /var/lib/lastfmproxy/data/sidebar.css
> lastfmproxy: /var/lib/lastfmproxy/data/sidebar.html
> lastfmproxy: /var/lib/lastfmproxy/data/song.png
> lastfmproxy: /var/lib/lastfmproxy/httpclient.py
> lastfmproxy: /var/lib/lastfmproxy/lastfm.py
> lastfmproxy: /var/lib/lastfmproxy/main.py
> lastfmproxy: /var/lib/lastfmproxy/playlist.py
> lastfmproxy: /var/lib/lastfmproxy/xspf.py
> 
> Additionally, this package does not follow python policy §2.6 (byte
> compilation of modules). The use of a python packaging helper such
> as dh_python2 would help with this.
> 
> (Line 3 of the postinst also means that any debhelper boilerplate
> added to the maintainer script will not be executed in a lot of cases
> which is not as desirable.)
> 
This might.

Cheers,
Julien

Attachment: signature.asc
Description: Digital signature

Reply via email to