On Sun, Dec 02, 2012 at 05:11:00PM +0600, Andrey Rahmatullin wrote: > 2. The code in KReportConfigurationFilterDlg::slotReset() doesn't have a > fallback and can leave m_comboDetail without a selected value. > 3. pl.po and possibly other langs have different values for the combo item > and the constant from the comparison. > > I also feel that it's wrong to have different contexts for that two > strings if they are compared but I don't know best practices for Qt > localization. See also https://bugs.kde.org/show_bug.cgi?id=258974 and https://projects.kde.org/projects/extragear/office/kmymoney/repository/revisions/7019c148079fbb9ba3d1b8331c09d2c994215c91/diff/kmymoney/dialogs/kreportconfigurationfilterdlg.cpp
-- WBR, wRAR
signature.asc
Description: Digital signature
