On Sat, Feb 15, 2014 at 12:03:39PM +1100, Aníbal Monsalve Salazar wrote:
> On Sat, Feb 15, 2014 at 12:03:22AM +0000, Debian FTP Masters wrote:
> > 
> > 
> > argus-server: lintian output: 'embedded-library usr/sbin/argus: libpcap', 
> > automatically rejected package.
> > argus-server: If you have a good reason, you may override this lintian tag.
> > 
> > ===
> > 
> > Please feel free to respond to this email if you don't understand why
> > your files were rejected, or if you upload new files which address our
> > concerns.
> 
> Hello Andrew,
> 
> The patch below is the debdiff between 3.0.0-3 and Steven's NMU.
> 
> The NMU was rejected as you could see above.
> 
> Do you think there is a good reason to override the lintian error?

I have no familiarity with argus 3.0. Someone else has packaged it for
experimental, not me.

On the face of it, I see no reason to be statically linking libpcap into
argus, so I don't think overriding the lintian error is the right approach.
 
> Regards,
> 
> Aníbal
> 
> debdiff argus_3.0.0-3.dsc argus_3.0.0-3.1.dsc
> diff -u argus-3.0.0/debian/rules argus-3.0.0/debian/rules
> --- argus-3.0.0/debian/rules
> +++ argus-3.0.0/debian/rules
> @@ -14,6 +14,7 @@
>  
>  export DEB_HOST_GNU_TYPE  ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
>  export DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
> +DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
>  
>  ifeq ($(DEB_BUILD_GNU_TYPE), $(DEB_HOST_GNU_TYPE))
>    confflags += --build $(DEB_HOST_GNU_TYPE)
> @@ -42,7 +43,8 @@
>       --bindir=/usr/bin \
>       --sysconfdir=/etc \
>       --mandir=/usr/share/man \
> -     --includedir=/usr/include CFLAGS="$(CFLAGS)"
> +     --includedir=/usr/include CFLAGS="$(CFLAGS)" \
> +     --with-libpcap=/usr/lib/$(DEB_HOST_MULTIARCH)
>       
>  binary-indep: build
>       dh_testroot
> diff -u argus-3.0.0/debian/changelog argus-3.0.0/debian/changelog
> --- argus-3.0.0/debian/changelog
> +++ argus-3.0.0/debian/changelog
> @@ -1,3 +1,10 @@
> +argus (2:3.0.0-3.1) experimental; urgency=medium
> +
> +  * Non-maintainer upload.
> +  * Set libpcap library path. Patch by Dejan Latinovic. Closes: #599972
> +
> + -- Steven J. Hill <steven.h...@imgtec.com>  Fri, 14 Feb 2014 20:39:51 +0000
> +
>  argus (2:3.0.0-3) experimental; urgency=low
>  
>    * debian/rules: make /var/log/argus 750 again


Attachment: signature.asc
Description: Digital signature

Reply via email to