On Thu, Nov 20, 2014 at 10:42:23PM +0100, Helmut Grohne wrote:
> Hi Wouter and Jean Baptiste,
>
> On Wed, Nov 19, 2014 at 11:35:50PM +0100, Wouter Verhelst wrote:
> > On Tue, Nov 18, 2014 at 01:48:04PM +0100, Jean Baptiste Favre wrote:
> > > * Remove debconf calls from ola-rdm-tests postinst. (Closes: #767676)
> > > * Fix other seriouys issues:
> > > - Provides missing /etc/default/ola from ola postinst script to allow
> > > olad service control in the same way rdm_test_server is
> >
> > NAK. /etc/default/* to manage service status is a menace, and should be
> > forbidden.
>
> Wouter, please bear in mind, that it is not the proposed NMU that is
> adding the need for an /etc/default/ola file. The current init script
> (debian/ola.olad.init) sources /etc/default/ola and doesn't start at all
> when it does not exist. This puts you in a bad position to demand
> otherwise.
Yes, I had missed that, sorry.
> Given the other things you said, I assume that it is not your intention
> for the init script to check for $RUN_DAEMON at all. (The issue is
> duplicated in the init script of ola-rdm-tests.)
>
> I suggest the following approach then:
>
> * Remove the check for $RUN_DAEMON from both init scripts (olad and
> rdm_test_server).
> * Do not ship the default files in either package.
> * Keep sourcing /etc/default/ola{,-rdm-tests} so users can change e.g.
> $DAEMON_ARGS.
>
> Optionally:
> * During upgrade, check whether the default files were unmodified (by
> comparing their md5sum to known values) and if they are unmodified,
> remove them.
>
> Wouter, do you agree with this approach?
Certainly.
[...]
--
It is easy to love a country that is famous for chocolate and beer
-- Barack Obama, speaking in Brussels, Belgium, 2014-03-26
--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
