On Sun, 16 Jun 2019 23:26:45 +0200 Andreas Beckmann <a...@debian.org> wrote:
> Followup-For: Bug #930005
> Control: tag -1 patch
>
> The attached patch fixes the linking issue and thus the missing tgetent
> symbol. Thereafter the command
> regina /usr/share/doc/regina-rexx/examples/regutil.rexx
> works on i386, but segfaults on amd64.
Hi all,
I have been looking into this package. Seems the amd64 segfault
disappears when we make sure termcap.h is loaded from the right
regutils file. I am attaching two additional patches for
debian/patches, one sets HAVE_TGETENT and the other makes sure
termcap.h is loaded if so.
Alen, I plan to upload a NMU with this changes and may be some minor
issues. Even if I have not written rexx for years I think it would be
a pity to have this package with this open bug.
Also, one issue with this package is that Debian build system is
ancient, even pre-debhelper. This makes everything a nightmare. I have
been playing with a migration to traditional (no dh sequencer)
debhelper. This should fix another bug report about build
reproduciibility. I am aware that this is a rather invasive change,
but I think is required to make contributors life easier, let me know
your POV.
Other thing I noticed is that this package has no repo under salsa. I
can prepare a git repo with regina history and put it under
salsa/debian group. Alen, please tell me if you object to this, I
consider it important and will proceed unless you object explicitly.
By the way, upstream is active and there are new versions available,
although I will focus on current upstream version in Debian.
Regards,
--
Agustin
Index: regina-rexx/regutil/regscreenux.c
===================================================================
--- regina-rexx.orig/regutil/regscreenux.c 2021-02-12 00:18:07.362794088 +0100
+++ regina-rexx/regutil/regscreenux.c 2021-02-12 00:22:30.733931644 +0100
@@ -34,6 +34,10 @@
# include <sys/ioctl.h>
#endif
+#ifdef HAVE_TGETENT
+# include <termcap.h>
+#endif
+
#if 0
#ifdef USE_TERMCAP_DB
# ifdef HAVE_TERM_H
Index: regina-rexx/configure.in
===================================================================
--- regina-rexx.orig/configure.in 2021-02-11 23:35:03.688015418 +0100
+++ regina-rexx/configure.in 2021-02-11 23:35:03.684015371 +0100
@@ -248,6 +248,9 @@
if test "$REGUTIL_TERM_LIB" = "none required" -o "$REGUTIL_TERM_LIB" = "no"; then
REGUTIL_TERM_LIB=""
fi
+if test "x$REGUTIL_TERM_LIB" != "x"; then
+AC_DEFINE([HAVE_TGETENT],[1],[Define if tgetent exist])
+fi
LIBS="$save_LIBS"
AC_SUBST(REGUTIL_TERM_LIB)
Index: regina-rexx/configure
===================================================================
--- regina-rexx.orig/configure 2021-02-11 23:35:02.932006415 +0100
+++ regina-rexx/configure 2021-02-11 23:35:36.260403347 +0100
@@ -5259,8 +5259,14 @@
if test "$REGUTIL_TERM_LIB" = "none required" -o "$REGUTIL_TERM_LIB" = "no"; then
REGUTIL_TERM_LIB=""
fi
+if test "x$REGUTIL_TERM_LIB" != "x"; then
+
+$as_echo "#define HAVE_TGETENT 1" >>confdefs.h
+
+fi
LIBS="$save_LIBS"
+
save_LIBS="$LIBS"
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for library containing crypt" >&5
$as_echo_n "checking for library containing crypt... " >&6; }
