Hi! On Tue, 2022-11-08 at 16:32:25 +0300, Michael Tokarev wrote: > On Tue, 08 Nov 2022 15:51:17 +0300 Michael Tokarev <m...@tls.msk.ru> wrote: > > Source: liburing > > Version: 2.3-1 > > Severity: grave > > > > liburing 2.3 broke binary compatibility without bumping the soname.
Indeed. :/ Should make a habit of checking the header diffs, as this is not the first time this has happened. > > In liburing.h in 2.3, structures io_uring_cq and io_uring_sq changed > > their sizes. Both of these structures are parts of io_uring structure > > which the main part of the API. Here's the difference: > > > > @@ -43,7 +79,9 @@ > > @@ -56,13 +94,18 @@ > > size_t ring_sz; > > void *ring_ptr; > > - unsigned pad[4]; > > + unsigned ring_mask; > > + unsigned ring_entries; > > + > > + unsigned pad[2]; > > This does not look like it is changing the size actually, - I haven't > noticed it adjusts pad[] accordingly. So this is not the issue here. > > But the end result is the same: samba compiled with liburing 2.2 does > not work with runtime liburing 2.3, and samba compiled with liburing > 2.3 does not work with runtime liburing 2.2. > > I'm just too tired now to dig further. The problem is that this release has deprecated the kring_mask and kring_entries, and does not have fallback code to use them if they are being used by the callers. I'll report this upstream to see how they want to fix this, either with a SOVERSION bump or trying to add dynamic fallback code or similar. For sid, I guess I could bump the affected functions required minimal versions in the symbols file, and then add breaks on the old packages using the old ABI, but meh. :/ Thanks, Guillem
