Your message dated Wed, 20 Mar 2024 19:36:50 +0000
with message-id <e1rn1k2-008dmo...@fasolo.debian.org>
and subject line Bug#1066811: fixed in cyrus-sasl2 2.1.28+dfsg1-5
has caused the Debian Bug report #1066811,
regarding cyrus-sasl2: assumes time_t fits into long for printf and scanf(!), 
will break on big endian
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1066811: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066811
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: cyrus-sasl2
Version: 2.1.28+dfsg1-4
Severity: serious
Justification: breaks
X-Debbugs-Cc: t...@mirbsd.de

cyrus-sasl2, before aborting the build due to #1066214, spews
several warnings like the following:

[…]
otp.c:648:43: warning: format '%ld' expects argument of type 'long int', but 
argument 7 has type 'time_t' {aka 'long long int'} [-Wformat=]
  648 |     sprintf(data, "%s\t%04d\t%s\t%s\t%020ld",
      |                                      ~~~~~^
      |                                           |
      |                                           long int
      |                                      %020lld
  649 |             alg, seq, seed, buf, timeout);
      |                                  ~~~~~~~
      |                                  |
      |                                  time_t {aka long long int}
otp.c:709:48: warning: format '%ld' expects argument of type 'long int *', but 
argument 7 has type 'time_t *' {aka 'long long int *'} [-Wformat=]
  709 |         sscanf(secret, "%s\t%04d\t%s\t%s\t%020ld",
      |                                           ~~~~~^
      |                                                |
      |                                                long int *
      |                                           %020lld
  710 |                alg, seq, seed, buf, timeout);
      |                                     ~~~~~~~
      |                                     |
      |                                     time_t * {aka long long int *}
[…]

These are actual problems that not only result in bad data
being printed or read but, if the time_t argument is not
(like here) the last one, also wrong arguments being used
for subsequent positional parameters.

Please fix *all* -Wformat mismatches involving time_t, for
example:

-       sprintf(data, "%s\t%04d\t%s\t%s\t%020ld",
+       sprintf(data, "%s\t%04d\t%s\t%s\t%020lld",
-           alg, seq, seed, buf, timeout);
+           alg, seq, seed, buf, (long long)timeout);

+       long long tmptimeout;
-       sscanf(secret, "%s\t%04d\t%s\t%s\t%020ld",
+       sscanf(secret, "%s\t%04d\t%s\t%s\t%020lld",
-           alg, seq, seed, buf, timeout);
+           alg, seq, seed, buf, tmptimeout);
+       timeout = tmptimeout;

Justification: I’ve been fixing bugs like these on MirBSD
since its i386 port switched to 64-bit time_t in 2004…

Thanks,
//mirabilos
-- 
16:47⎜«mika:#grml» .oO(mira ist einfach gut....)      23:22⎜«mikap:#grml»
mirabilos: und dein bootloader ist geil :)    23:29⎜«mikap:#grml» und ich
finds saugeil dass ich ein bsd zum booten mit grml hab, das muss ich dann
gleich mal auf usb-stick installieren   -- Michael Prokop über MirOS bsd4grml

--- End Message ---
--- Begin Message ---
Source: cyrus-sasl2
Source-Version: 2.1.28+dfsg1-5
Done: Bastian Germann <b...@debian.org>

We believe that the bug you reported is fixed in the latest version of
cyrus-sasl2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1066...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bastian Germann <b...@debian.org> (supplier of updated cyrus-sasl2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 20 Mar 2024 19:03:11 +0000
Source: cyrus-sasl2
Architecture: source
Version: 2.1.28+dfsg1-5
Distribution: unstable
Urgency: medium
Maintainer: Debian Cyrus Team <team+cy...@tracker.debian.org>
Changed-By: Bastian Germann <b...@debian.org>
Closes: 1065436 1066214 1066811
Changes:
 cyrus-sasl2 (2.1.28+dfsg1-5) unstable; urgency=medium
 .
   * Team upload
   * Fix implicit function declaration (Closes: #1066214)
   * Prevent linking via intersphinx (Closes: #1065436)
   * Extend the time_t format specifiers to long long (Closes: #1066811)
Checksums-Sha1:
 ba6ea0c0400f58f50568d88a075a5a7da2ce3d8a 3224 cyrus-sasl2_2.1.28+dfsg1-5.dsc
 3cc7781596618e4f0af1b860e8d51f0eb823289e 98016 
cyrus-sasl2_2.1.28+dfsg1-5.debian.tar.xz
 cd9b4d540c54095c9258999ddb9d38a744c2a4a9 10151 
cyrus-sasl2_2.1.28+dfsg1-5_source.buildinfo
Checksums-Sha256:
 f6021b29dd8e1e94c094bd97d001309888b299be000556012f0c811009ed91ab 3224 
cyrus-sasl2_2.1.28+dfsg1-5.dsc
 53ac81c1e519814f5bcda3ef2d7f0070060948301b045bdbee9ebdfb2cbe6982 98016 
cyrus-sasl2_2.1.28+dfsg1-5.debian.tar.xz
 a8b8677b07b2b289a4e7c50df2bf7126febf6daf732f9c19f42d8fc24b5ca1dd 10151 
cyrus-sasl2_2.1.28+dfsg1-5_source.buildinfo
Files:
 9c23dda1425c1d1a54462837c8dcc834 3224 libs optional 
cyrus-sasl2_2.1.28+dfsg1-5.dsc
 9fa57f43af5c2febb28bc19254a08277 98016 libs optional 
cyrus-sasl2_2.1.28+dfsg1-5.debian.tar.xz
 3c47c773735c77027ca62e87bda6c1c9 10151 libs optional 
cyrus-sasl2_2.1.28+dfsg1-5_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQHEBAEBCgAuFiEEQGIgyLhVKAI3jM5BH1x6i0VWQxQFAmX7NfQQHGJhZ2VAZGVi
aWFuLm9yZwAKCRAfXHqLRVZDFN2gC/4zAUi84gCfLPlOA+ZwdEq10xzO7TTMEGqT
788ymRPcp082Z/LxajvuqBhgSsvQOX7Fhlq34eWlFZH3mFr+4MBEF0RV/lBTAUMB
Sz4uWTOIOaPl7C1E/V9Ck8JmuLzOT8fKZ9nYfv+/nA8d7TSpC0kRFWWTx1qC8vKs
lVN4TKjIrHhkPv4REGepeouD2Q1j6hmWIAISdyXF/xG7D5l3tdLQYR+4vZHZJ4Da
kRtvk/g1qARZWd+MyoS0ZFskai/VeC1fV5pFK5K4UYsxsmZMkb2zlG20IXxgeqUu
cVMTQFl+EpGt7+winu7hRUKMOE8FDlkxafhfMIWJ3yeJlUhnODG1Fp9Kq88Ur3EF
MrbRNFDb+L/G4eEGqyU3qC7BRvNXKxx/NvoU4SYn0XklRxS1FY9a8yDPNreakx2k
YkwzjQV0kPZZPSR0z4b00AaHQzZ23OE9dMsCyVcigFT2k4tLNZyN6URbxYOCZlOl
x+/F6jqrNqCMBHOeYwVq/6GsVbVWv2Q=
=TKMm
-----END PGP SIGNATURE-----

Attachment: pgp2LTodST3jo.pgp
Description: PGP signature


--- End Message ---

Reply via email to