Bug#1066355: spotlighter: FTBFS: spotlighter.c:105:3: error: implicit declaration of function ‘on_window_screen_changed’ [-Werror=implicit-function-declaration]

[Vladimir Petko]

Package: spotlighter
Followup-For: Bug #1066355
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Dear Maintainer,

Would it be possible to consider the attached patch as the solution for the
issue?

In Ubuntu, the attached patch was applied to achieve the following:

  * d/p/2_ftbfs_implicit_declaration.patch: declare callback to
    resolve -Werror=implicit-function-declaration ftbfs (LP: #2061331).


Thanks for considering the patch.


-- System Information:
Debian Release: trixie/sid
  APT prefers mantic-updates
  APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 
'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-27-generic (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

diff -Nru spotlighter-0.3/debian/patches/02_ftbfs_implicit_declaration.patch 
spotlighter-0.3/debian/patches/02_ftbfs_implicit_declaration.patch
--- spotlighter-0.3/debian/patches/02_ftbfs_implicit_declaration.patch  
1970-01-01 12:00:00.000000000 +1200
+++ spotlighter-0.3/debian/patches/02_ftbfs_implicit_declaration.patch  
2024-04-15 10:55:20.000000000 +1200
@@ -0,0 +1,18 @@
+Description: add callback declaration
+ Add callback declaration to resolve -Werror=implicit-function-declaration.
+Author: Vladimir Petko <vladimir.pe...@canonical.com>
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066355
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/spotlighter/+bug/2061331
+Forwarded: no
+Last-Update: 2024-04-15
+
+--- a/src/callbacks.h
++++ b/src/callbacks.h
+@@ -33,3 +33,7 @@
+                          gpointer    data);
+
+
++G_MODULE_EXPORT void
++on_window_screen_changed       (GtkWidget  *widget,
++                                GdkScreen  *previous_screen,
++                                gpointer    user_data);
diff -Nru spotlighter-0.3/debian/patches/series 
spotlighter-0.3/debian/patches/series
--- spotlighter-0.3/debian/patches/series       2024-04-01 21:03:10.000000000 
+1300
+++ spotlighter-0.3/debian/patches/series       2024-04-15 10:55:20.000000000 
+1200
@@ -1,3 +1,4 @@
 00_desktop.patch
 01_ftbfs_mips.patch
 no_AM_PATH_GTK_3_0.diff
+02_ftbfs_implicit_declaration.patch