Your message dated Tue, 16 Apr 2024 23:25:17 +0200
with message-id <zh7svrb+j0rvt...@brokenwa.re>
and subject line Re: Bug#1065169: debsources: incomplete support for 
non-free-firmware
has caused the Debian Bug report #1065169,
regarding debsources: incomplete support for non-free-firmware
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1065169: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1065169
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: qa.debian.org
User: qa.debian....@packages.debian.org
Usertag: debsources
Severity: important

Hi,

While waiting for an update run on sor.d.o to finish earlier today (so
I could add a little disk space to /srv) I noticed some errors in the
logs relating to non-free-firmware packages; e.g.:

2024-03-01 08:59:19 updater:ERROR failed to add 
nvidia-graphics-drivers/525.147.05-7~deb12u1
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/sqlalchemy/engine/base.py", line 1276, 
in _execute_context
    self.dialect.do_execute(
  File "/usr/lib/python3/dist-packages/sqlalchemy/engine/default.py", line 609, 
in do_execute
    cursor.execute(statement, parameters)
psycopg2.errors.StringDataRightTruncation: value too long for type character 
varying(8)

This appears to be because MR!6 didn't change the size of the field in
lib/debsources/models.py and "non-free-firmware" is obviously larger
than 8 characters.

I assume this needs a database migration as well as a change to
models.py, but it's not completely clear to me how/when those get
applied, particularly as 011-to-012.sql has existed since early 2020
but models.py still specifies DB_SCHEMA_VERSION as 11.

Regards,

Adam

--- End Message ---
--- Begin Message ---
Hi,

On Fri, Mar 01, 2024 at 11:40:59AM +0000, Adam D. Barratt wrote:
> While waiting for an update run on sor.d.o to finish earlier today (so
> I could add a little disk space to /srv) I noticed some errors in the
> logs relating to non-free-firmware packages; e.g.:

Thanks for this!

> 2024-03-01 08:59:19 updater:ERROR failed to add 
> nvidia-graphics-drivers/525.147.05-7~deb12u1
> Traceback (most recent call last):
>   File "/usr/lib/python3/dist-packages/sqlalchemy/engine/base.py", line 1276, 
> in _execute_context
>     self.dialect.do_execute(
>   File "/usr/lib/python3/dist-packages/sqlalchemy/engine/default.py", line 
> 609, in do_execute
>     cursor.execute(statement, parameters)
> psycopg2.errors.StringDataRightTruncation: value too long for type character 
> varying(8)
> 
> This appears to be because MR!6 didn't change the size of the field in
> lib/debsources/models.py and "non-free-firmware" is obviously larger
> than 8 characters.
> 
> I assume this needs a database migration as well as a change to
> models.py, but it's not completely clear to me how/when those get
> applied, particularly as 011-to-012.sql has existed since early 2020
> but models.py still specifies DB_SCHEMA_VERSION as 11.

And for the report. I removed the constraint varchar(8), it is now
varchar. And got rid of DB_SCHEMA_VERSION, which was indeed outdated
and unused.

Cheers,
--
Matthieu

Attachment: signature.asc
Description: PGP signature


--- End Message ---

Reply via email to