control: owner -1 "Mohammed Sadiq <sa...@sadiqpk.org>"
control: affects -1 src:gnome-kiosk
Thank you Mohammed for working on packaging this. Here is your first review.
1. Please remove debian/control.in, the first few commented lines of
debian/control, and debian/control's Build-Depends: dh-sequence-gnome
The Debian GNOME team has deprecated debian/control.in and is in the
slow process of removing it across their team packages.
dh-sequence-gnome is now only needed for some packages.
2. This package will not build in Experimental (which is where we are
targeting it for now) because it is missing Build-Depends:
libgtk-4-dev
3. Please Build-Depend on dconf-cli instead of libdconf-dev.
meson.build has find_program('dconf') and dconf-cli ships
/usr/bin/dconf
4. I think the ftpmasters will not like that Red Hat is listed in your
debian/copyright but isn't mentioned in the source at all. There are a
few different ways to fix this. One way is to add a Comment field at
the end of the Red Hat paragraph pointing to
https://gitlab.gnome.org/GNOME/gnome-kiosk/-/commit/9cf264d
5. Let's split the package like Fedora did. You can see the file
structure for Fedora's split at
https://koji.fedoraproject.org/koji/buildinfo?buildID=2291875 . Click
info next to the rpm files for noarch (this is equivalent to Debian's
arch: all) and x86_64. Ignore the debuginfo and debugsource files.
For reference, here is Fedora's spec file:
https://src.fedoraproject.org/rpms/gnome-kiosk/blob/f39/f/gnome-kiosk.spec
Thank you,
Jeremy Bícha
