Public bug reported:

Hi all!

In nautilus : debian/patches/ubuntu_titlebar_css.patch

you have defined some style override in order to fit (if I understood
correctly) nautilus in Unity window decoration.

But, instead to check if it's Unity the current window manager, you do
this:

+       settings = gtk_settings_get_default();
+       g_object_get(settings, "gtk-theme-name", &theme_name, NULL);
+
+       if (g_strcmp0(theme_name, "Ambiance") == 0 || g_strcmp0(theme_name, 
"Radiance") == 0)

Which means: if you change theme in a Unity session, Nautilus will not
override style. And also: if you use those themes in any window manager,
nautilus makes the override.

You should check XDS_CURRENT_DESKTOP == 'Unity' instead to look for
which Theme is in use.

** Affects: nautilus (Ubuntu)
     Importance: Undecided
         Status: New

** Description changed:

  Hi all!
  
- In nuautilus : debian/patches/ubuntu_titlebar_css.patch
+ In nautilus : debian/patches/ubuntu_titlebar_css.patch
  
  you have defined some style override in order to fit (if I understood
  correctly) nautilus in Unity window decoration.
  
  But, instead to check if it's Unity the current window manager, you do
  this:
  
  +     settings = gtk_settings_get_default();
  +     g_object_get(settings, "gtk-theme-name", &theme_name, NULL);
  +
  +     if (g_strcmp0(theme_name, "Ambiance") == 0 || g_strcmp0(theme_name, 
"Radiance") == 0)
  
+ Which means: if you change theme in a Unity session, Nautilus will not
+ override style. And also: if you use those themes in any window manager,
+ nautilus makes the override.
  
- Which means: if you change theme in a Unity session, Nautilus will not 
override style. And also: if you use those themes in any window manager, 
nautilus makes the override.
- 
- You should check instead XDS_CURRENT_DESKTOP == 'Unity'. Or is there
- some better way to know which WindowManager is running ?
+ You should check XDS_CURRENT_DESKTOP == 'Unity' instead to look for
+ which Theme is in use.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/1302077

Title:
  Hardcoded css style checks on GTK Theme instead of XGD_CURRENT_DESKTOP

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1302077/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

Reply via email to