** Description changed:

  [ Impact ]
  
  When mounting an external location a script is used to get the current
  default app for a type, its return error is parsed by the dock to
  provide users a feedback, but the returned code is not valid in case of
  error.
  
  [ Test case ]
  
  Run:
-   gjs -m 
/usr/share/gnome-shell/extensions/ubuntu-d...@ubuntu.com/locationsWorker.js 
/foo/bar/baz
-   echo $?
+   gjs -m 
/usr/share/gnome-shell/extensions/ubuntu-d...@ubuntu.com/locationsWorker.js 
handler /foo/bar/baz
+   echo $?
  
  An error should be shown and the return code should be 15
  
  Doing instead
  
-   gjs -m 
/usr/share/gnome-shell/extensions/ubuntu-d...@ubuntu.com/locationsWorker.js 
$HOME
-   echo $?
+   gjs -m 
/usr/share/gnome-shell/extensions/ubuntu-d...@ubuntu.com/locationsWorker.js 
handler $HOME
+   echo $?
  
  The file manager desktop-id should be printed and the script should
  return 0.
  
  [ Regression Potential ]
  
  Some locations may not have a default handler and so not being launched

** Description changed:

  [ Impact ]
  
  When mounting an external location a script is used to get the current
  default app for a type, its return error is parsed by the dock to
  provide users a feedback, but the returned code is not valid in case of
  error.
  
  [ Test case ]
  
  Run:
-   gjs -m 
/usr/share/gnome-shell/extensions/ubuntu-d...@ubuntu.com/locationsWorker.js 
handler /foo/bar/baz
+   gjs -m 
/usr/share/gnome-shell/extensions/ubuntu-d...@ubuntu.com/locationsWorker.js 
handler file:///foo/bar/baz
    echo $?
  
  An error should be shown and the return code should be 15
  
  Doing instead
  
-   gjs -m 
/usr/share/gnome-shell/extensions/ubuntu-d...@ubuntu.com/locationsWorker.js 
handler $HOME
+   gjs -m 
/usr/share/gnome-shell/extensions/ubuntu-d...@ubuntu.com/locationsWorker.js 
handler file://$HOME
    echo $?
  
  The file manager desktop-id should be printed and the script should
  return 0.
  
  [ Regression Potential ]
  
  Some locations may not have a default handler and so not being launched

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gnome-shell-extension-ubuntu-dock in
Ubuntu.
https://bugs.launchpad.net/bugs/2038783

Title:
  Exit code of locations mount script is not respecting error

Status in gnome-shell-extension-ubuntu-dock package in Ubuntu:
  Fix Released
Status in gnome-shell-extension-ubuntu-dock source package in Mantic:
  Fix Committed

Bug description:
  [ Impact ]

  When mounting an external location a script is used to get the current
  default app for a type, its return error is parsed by the dock to
  provide users a feedback, but the returned code is not valid in case
  of error.

  [ Test case ]

  Run:
    gjs -m 
/usr/share/gnome-shell/extensions/ubuntu-d...@ubuntu.com/locationsWorker.js 
handler file:///foo/bar/baz
    echo $?

  An error should be shown and the return code should be 15

  Doing instead

    gjs -m 
/usr/share/gnome-shell/extensions/ubuntu-d...@ubuntu.com/locationsWorker.js 
handler file://$HOME
    echo $?

  The file manager desktop-id should be printed and the script should
  return 0.

  [ Regression Potential ]

  Some locations may not have a default handler and so not being
  launched

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-shell-extension-ubuntu-dock/+bug/2038783/+subscriptions


-- 
Mailing list: https://launchpad.net/~desktop-packages
Post to     : desktop-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~desktop-packages
More help   : https://help.launchpad.net/ListHelp

Reply via email to