davoustp opened a new pull request #476:
URL: https://github.com/apache/struts/pull/476


   The localized resources lookup shows high contention during significant 
stress in an enterprise application delivering the UI using Struts 2.5.20.
   
   Profiling the app while under load stress using the excellent 
https://github.com/jvm-profiling-tools/async-profiler (using the `lock` mode 
and `--reverse` option to aggregate on the various contention code locations) 
shows the following picture:
   
   
![image](https://user-images.githubusercontent.com/2195557/111143750-7a5d9f80-8586-11eb-9890-a295d6e592ca.png)
   
   No other high contention code paths was detected (profiler obviously shows 
high lock wait times on EPoll and other `java.util.concurrent`-related waits, 
which are irrelevant here): this code path is the main contention culprit.
   
   Switching to the concurrent version of `Set` fixes entirely the issue: no 
more contention detected in this area after applying the fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

Reply via email to