JCgH4164838Gh792C124B5 opened a new pull request #489: URL: https://github.com/apache/struts/pull/489
WW-5124 - Proposed fix for Struts JSP tag behaviour on application servers that use tag pooling. - Prior to this change, on application serves such as Glassfish, tag pools that re-use tag instances demonstrated incorrect behaviour, due to previous / old tag state still being present. - Added new clearTagStateForTagPoolingServers() to StrutsBodyTagSupport. It is called in doEndTag(), and descendants that override doEndTag() should call the ancestor method or directly call clearTagStateForTagPoolingServers(). - Unit test support methods were added to StrutsInternalTestCase and AbstractTagTest. - Basic sanity checks for existing unit tests were added where feasible. They reflection-compare a tag's state after doEndTag() is called with that of a new instance, to help catch if future changes miss calls in the clearTagStateForTagPoolingServers() hierarchy. - Removed some unused imports, added some missing override annotations to classes that were modified as part of this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
