vongosling - "Do we have a plan to transfer all pg files to an external directory?"
Could you please clarify what *you *mean by an external directory? Is it another directory in our repository or not in our repository at all? Additionally, is this a requirement? Per Justin, or at least from my understanding of what Justin stated and please correct me if I am wrong, it is desirable to keep the code in another directory in the repository but, it is not necessary. What we have been working on is slowly migrating code out of these files and trying to segregate our new code. However, this is a slow process as there are a lot of interdependencies. Additionally, as the core code for AGE is heavily based off of JSONB, some of our code cannot be fully separated or segregated. So, to answer your question, yes, we have been working on a plan to separate and segregate our code. But, to an external directory, that depends on what you mean. There will always be files with a mix of our code and PG code due to the nature of this extension - which has been stated before. John On Sun, Jan 23, 2022 at 7:14 PM vongosling <vongosl...@apache.org> wrote: > Do we have a plan to transfer all pg files to an external directory? I have > seen we have many files like we have pointed. > > Josh Innis <josh.in...@bitnine.net> 于2022年1月24日周一 02:03写道： > > > There is some code that the AGE team wrote that is in those files, but no > > third party code is in those files. > > > > On Sun, Jan 23, 2022 at 8:46 AM John Gemignani <jrgemign...@gmail.com> > > wrote: > > > > > Hi Juan, > > > > > > Not necessarily the file names but the contents of those files. > > > > > > > > > John > > > > > > On Sun, Jan 23, 2022, 3:31 AM Juan Pan <panj...@apache.org> wrote: > > > > > > > Hi Josh, > > > > > > > > > > > > I see. I just want to double check the following files all comes from > > > > PostgreSQL, not from others, right? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > > Juan Pan(Trista), Twitter: @tristaZero > > > > > > > > > > > > On 01/23/2022 11:43，Josh Innis<josh.in...@bitnine.net> wrote： > > > > Hi Trista, > > > > > > > > From the discussion from the last release the team reviewed the > project > > > and > > > > determined that there was a large enough amount of the Postgres code > > base > > > > in those files to warrant the Postgres header instead of the Apache > > > > header. > > > > > > > > On Sat, Jan 22, 2022 at 6:35 AM Juan Pan <panj...@apache.org> wrote: > > > > > > > > Hello, > > > > > > > > > > > > > > > > [x] Download links are valid. > > > > > > > > [x] Checksums and PGP signatures are valid. > > > > > > > > [x] LICENSE, NOTICE and DISCLAIMER files exist. > > > > > > > > [ ] All files have license headers if necessary. > > > > > > > > > > > > > > > > > > > > The following files with source coding are all from Postgres project? > > > > ———— > > > > apache-age-0.7.0-incubating/.gitignore > > > > apache-age-0.7.0-incubating/.travis.yml > > > > apache-age-0.7.0-incubating/CONTRIBUTING.md > > > > apache-age-0.7.0-incubating/README.md > > > > apache-age-0.7.0-incubating/doc/.gitignore > > > > apache-age-0.7.0-incubating/drivers/golang/README.md > > > > apache-age-0.7.0-incubating/drivers/golang/TYPES.md > > > > apache-age-0.7.0-incubating/drivers/golang/parser/README.md > > > > apache-age-0.7.0-incubating/drivers/nodejs/README.md > > > > apache-age-0.7.0-incubating/drivers/python/README.md > > > > apache-age-0.7.0-incubating/drivers/python/antlr/README.md > > > > > > > > > > > > > > apache-age-0.7.0-incubating/drivers/python/samples/apache-age-agtypes.ipynb > > > > > > apache-age-0.7.0-incubating/drivers/python/samples/apache-age-basic.ipynb > > > > > > apache-age-0.7.0-incubating/drivers/python/samples/apache-age-note.ipynb > > > > apache-age-0.7.0-incubating/regress/.gitignore > > > > apache-age-0.7.0-incubating/src/backend/executor/cypher_utils.c > > > > apache-age-0.7.0-incubating/src/backend/parser/.gitignore > > > > apache-age-0.7.0-incubating/src/backend/parser/cypher_clause.c > > > > apache-age-0.7.0-incubating/src/backend/parser/cypher_expr.c > > > > apache-age-0.7.0-incubating/src/backend/parser/cypher_item.c > > > > apache-age-0.7.0-incubating/src/backend/parser/cypher_keywords.c > > > > apache-age-0.7.0-incubating/src/backend/parser/cypher_parse_agg.c > > > > apache-age-0.7.0-incubating/src/backend/parser/cypher_parse_node.c > > > > apache-age-0.7.0-incubating/src/backend/utils/ag_func.c > > > > apache-age-0.7.0-incubating/src/backend/utils/adt/ag_float8_supp.c > > > > apache-age-0.7.0-incubating/src/backend/utils/adt/agtype.c > > > > apache-age-0.7.0-incubating/src/backend/utils/adt/agtype_parser.c > > > > apache-age-0.7.0-incubating/src/backend/utils/adt/agtype_util.c > > > > apache-age-0.7.0-incubating/src/include/parser/.gitignore > > > > apache-age-0.7.0-incubating/src/include/parser/ag_scanner.h > > > > apache-age-0.7.0-incubating/src/include/parser/cypher_expr.h > > > > apache-age-0.7.0-incubating/src/include/parser/cypher_parse_agg.h > > > > apache-age-0.7.0-incubating/src/include/utils/ag_float8_supp.h > > > > apache-age-0.7.0-incubating/src/include/utils/ag_func.h > > > > apache-age-0.7.0-incubating/src/include/utils/agtype.h > > > > apache-age-0.7.0-incubating/src/include/utils/agtype_parser.h > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > > Juan Pan(Trista), Twitter: @tristaZero > > > > > > > > > > > > On 01/19/2022 07:37，Dehowe Feng<dehowe.f...@bitnine.net> wrote： > > > > Dear Apache Community, > > > > > > > > This is an official vote for the Apache AGE release 0.7.0. that we > have > > > > been > > > > working toward it. > > > > > > > > To learn more about Apache AGE, please see http://age.apache.org/ > > > > > > > > Functionalities included and addressed in this release: > > > > > > > > *Add VLE core to the MATCH clause. > > > > *Added support for various list functions > > > > *range() > > > > *relationships() > > > > *keys() > > > > *label() > > > > *nodes() > > > > *reverse() > > > > *Various bug fixes > > > > > > > > ***************************************************************** > > > > > > > > The git tag to be discussed and voted upon: > > > > https://github.com/apache/incubator-age/releases/tag/v.0.7.0-rc0 > > > > > > > > The git commit hash: commit d0175f4a2fb03f28c356ea43da3bd48a47f5ef42 > > > > > > > > The release files for 0.7.0, can be found at: > > > > https://dist.apache.org/repos/dist/dev/incubator/age/0.7.0.rc0/ > > > > > > > > Signatures used for AGE RCs can be found in this file: > > > > https://downloads.apache.org/incubator/age/KEYS > > > > > > > > The fingerprint of key to sign release artifacts: > > > > 847F A9F0 CB17 2A51 DEC9 D0F3 8285 D595 875F 13B1 > > > > > > > > For information about the contents of this release, see: > > > > https://github.com/apache/incubator-age/releases/tag/v.0.7.0-rc0 > > > > > > > > > > > > > > > > Please vote: > > > > > > > > > > > > [ ] +1 Release this package as Apache AGE 0.7.0 > > > > [ ] 0 I won't get in the way > > > > [ ] -1 Do not release this package because ... > > > > > > > > > > > > This vote will be open for 72 hours. > > > > > > > > Thank you for your time. > > > > > > > > > > > > Best, > > > > Dehowe Feng > > > > > > > > > > > > > > > > -- > Best Regards :-) >
