Thanks Andy, Jake and L.C. > Note that I still had to set RUST_MIN_STACK to avoid a stack overflow. I don't know if that is still expected.
Yes I do think that is still expected unfortunately and is consistent with the 37.0.0 release[1] (we didn't change anything in 37.1.0 RC1 that would alter this behavior unfortunately) However, I am quite pleased that the overflow *is* fixed on main (what will become 38.0.0), due to several improvements including [2]. Andrew [1]: https://lists.apache.org/thread/lwdflob72q7t7mqqxnqcobjzqjbc218o [2]: https://github.com/apache/arrow-datafusion/pull/10023 On Thu, Apr 18, 2024 at 11:25 AM L. C. Hsieh <vii...@gmail.com> wrote: > +1 (binding) > > Verified on M3 Mac. Tests are passed with RUST_MIN_STACK. > > Thanks Andrew. > > On Thu, Apr 18, 2024 at 7:51 AM vin jake <jakevin...@gmail.com> wrote: > > > > +1(binding) > > > > Thanks alamb for your work and efforts. > > > > > > > > On Thu, Apr 18, 2024 at 10:01 PM Andrew Lamb <al...@influxdata.com> > wrote: > > > > > Hi, > > > > > > I would like to propose a release of Apache Arrow DataFusion > > > Implementation, > > > version 37.1.0, a patch release with some bug fixes. Please see [4] for > > > details. > > > There is a failing CI test which only affects development tools [6]. > > > > > > While DataFusion is now officially its own top level Apache project, > we do > > > not yet have enough infrastructure (email lists) setup to do voting > > > there[5], so I would like to do this one last time on the arrow list. > > > > > > This release candidate is based on commit: > > > d4eb72c30d45c0f3f359c64f41a6caed30abe750 [1] > > > The proposed release tarball and signatures are hosted at [2]. > > > The changelog is located at [3]. > > > > > > Please download, verify checksums and signatures, run the unit tests, > and > > > vote > > > on the release. The vote will be open for at least 72 hours. > > > > > > Only votes from PMC members are binding, but all members of the > community > > > are > > > encouraged to test the release and vote with "(non-binding)". > > > > > > The standard verification procedure is documented at > > > > > > > https://github.com/apache/arrow-datafusion/blob/main/dev/release/README.md#verifying-release-candidates > > > . > > > > > > [ ] +1 Release this as Apache Arrow DataFusion 37.1.0 > > > [ ] +0 > > > [ ] -1 Do not release this as Apache Arrow DataFusion 37.1.0 because... > > > > > > Here is my vote: > > > > > > +1 > > > > > > [1]: > > > > > > > https://github.com/apache/arrow-datafusion/tree/d4eb72c30d45c0f3f359c64f41a6caed30abe750 > > > [2]: > > > > > > > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-37.1.0-rc1 > > > [3]: > > > > > > > https://github.com/apache/arrow-datafusion/blob/d4eb72c30d45c0f3f359c64f41a6caed30abe750/CHANGELOG.md > > > [4]: https://github.com/apache/arrow-datafusion/issues/9904 > > > [5]: https://github.com/apache/arrow-datafusion/issues/9691 > > > [6]: > > > > > > > https://github.com/apache/arrow-datafusion/pull/10128#issuecomment-2063655318 > > > . > > > >
