iwasakims commented on code in PR #1244:
URL: https://github.com/apache/bigtop/pull/1244#discussion_r1578880048
##########
bigtop_toolchain/bin/puppetize.sh:
##########
@@ -81,7 +81,7 @@ case ${ID}-${VERSION_ID} in
dnf config-manager --set-enabled codeready-builder-for-rhel-8-rhui-rpms
;;
openEuler-*)
- dnf -y install hostname curl sudo unzip wget ruby ruby-devel vim
systemd-devel findutils 'dnf-command(config-manager)' nc initscripts
openeuler-lsb openssl-devel make gcc-c++ openEuler-rpm-config python3-pip
python3-devel dbus
+ dnf -y install hostname curl sudo unzip wget ruby ruby-devel vim
systemd-devel findutils 'dnf-command(config-manager)' nc initscripts
openeuler-lsb openssl-devel make gcc-c++ openEuler-rpm-config python3-pip
python3-devel dbus python3-unversioned-command
Review Comment:
puppetize.sh should not have resources unrelated to Puppet setup . If the
package is required for building products, Puppet manifest of bigtop_toolchain
should be updated. If it is only required for smoke-tests,
`deploy/puppet/manifests/python.pp` should be updated. @MacChen01
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@bigtop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
