Your PR is a superset of the changes I made. Links to insecure pages will not cause the problem that Julian experienced, only resources which are requested when rendering the page (images, CSS, JS, etc.) I still think we should fix any HTTPS links. Have you verified that all the sites whose links you replaced actually support HTTPS? Just want to make sure we don't end up with anything broken, but I think we should merge your PR as well. Thanks! -- Michael Mior mm...@uwaterloo.ca
Le mar. 8 oct. 2019 à 13:16, Stamatis Zampetakis <zabe...@gmail.com> a écrit : > > I fired CALCITE-3391 and its respective PR this morning. > > @Michael: If your changes are sufficient then feel free to close the > respective JIRA/PR. > > Best, > Stamatis > > On Tue, Oct 8, 2019, 6:49 PM Michael Mior <mm...@apache.org> wrote: > > > Pushed and this seems to have resolved the issue for me. > > -- > > Michael Mior > > mm...@apache.org > > > > Le mar. 8 oct. 2019 à 12:39, Michael Mior <mm...@apache.org> a écrit : > > > > > > Most of the warnings I see are like the below. Switching this to HTTPS > > > should solve most of the issues. I'll make the change. > > > > > > http://github.com/zabetak.png > > > > > > -- > > > Michael Mior > > > mm...@apache.org > > > > > > Le lun. 7 oct. 2019 à 15:31, Julian Hyde <jh...@apache.org> a écrit : > > > > > > > > When I open https://calcite.apache.org/news/ < > > https://calcite.apache.org/news/> or https://calcite.apache.org/community/ > > <https://calcite.apache.org/community/> pages in Chrome, I get an (i) to > > the left of the URL bar with the message “Your connection to this site is > > not fully secure” and a warning on the right side of the URL bar with > > “Cookies blocked”. > > > > > > > > Other pages on the site seem to be OK - they display a padlock rather > > than an (i) at the left of the URL, indicating that the site is secure. > > > > > > > > Any idea what is wrong with the Community and News pages? > > > > > > > > Julian > > > > > >
