Hi Jin, If the test run fine locally at your machine (e.g., ./gradlew testSlow) then they should be fine in the CI. Labels are only available for committers yes!
Best, Stamatis On Fri, Dec 13, 2019 at 4:52 PM XING JIN <jinxing.co...@gmail.com> wrote: > Thanks a lot Ruben ~ > I'm working on "[CALCITE-3478] Restructure tests for materialized views" ( > https://github.com/apache/calcite/pull/1560) , which contains "slow > tests". > But I'm not sure how to add the label to PR. Is it only available for > committers ? > BTW, It's great if someone can help review > https://github.com/apache/calcite/pull/1560 . I've rebased the PR to > resolve conflicts for several times. > > Best, > Jin > > Ruben Q L <rube...@gmail.com> 于2019年12月13日周五 下午4:00写道： > > > Hi Jin, > > > > this is the expected behavior: slow tests are not executed by default in > PR > > CI. > > If you want slow tests to be executed in your PR, you need to explicitly > > add the label "slow-tests-needed", as specified by [1]. > > You can see a PR example with this label here [2]. > > > > Best regards, > > Ruben > > > > [1] https://issues.apache.org/jira/browse/CALCITE-3141 > > [2] https://github.com/apache/calcite/pull/1651 > > > > > > Le ven. 13 déc. 2019 à 08:41, XING JIN <jinxing.co...@gmail.com> a > écrit : > > > > > Hi guys, > > > I made a PR and run continuous integration tests. [1] > > > A error test contained in the PR and tagged with @slowTest. > > > The tests should be failed but CI passed by mistake. > > > I doubt our current CI is not running with 'testSlow' configuration. > > Isn't > > > it ? > > > I'm not sure if I should create a JIRA. > > > > > > Best, > > > Jin > > > > > > [1] https://github.com/apache/calcite/pull/1653 > > > > > >
