Andrei, Your key’s signature appears in KEYS because you signed Stamatis’s key. But your key isn’t actually defined in the file. After I imported the file, your key was still ‘unknown’ according to gpg.
Julian > On Aug 11, 2020, at 8:04 AM, Andrei Sereda <and...@sereda.cc> wrote: > > >> >> * Andrei, I don’t think your key is in KEYS. Be sure to add it before the > release announcement. > > I see my signing key in KEYS > $ curl -s https://dist.apache.org/repos/dist/release/calcite/KEYS | grep > sereda > sig C41CFDDFED34C028 2019-08-19 Andrei Sereda (CODE SIGNING KEY) < > ser...@apache.org> > sig C41CFDDFED34C028 2019-08-19 Andrei Sereda (CODE SIGNING KEY) < > ser...@apache.org> > >> * There are several files in the source distro that are not in git: an > empty ‘arrow’ directory, and a non-empty ‘licenses’ directory. > Yes you're right. I presume you're still OK with RC0 (judging by your +1) ? > > >> On Tue, Aug 11, 2020 at 5:53 AM Julian Hyde <jhyde.apa...@gmail.com> wrote: >> >> +1 (binding) >> >> Checked keys, hashes, LICENSE, NOTICE, README; compiled and ran tests on >> Ubuntu/JDK 14; ran RAT. >> >> * Andrei, I don’t think your key is in KEYS. Be sure to add it before the >> release announcement. >> >> * There are several files in the source distro that are not in git: an >> empty ‘arrow’ directory, and a non-empty ‘licenses’ directory. >> >> Julian >> >> >>> On Aug 11, 2020, at 2:33 AM, Stamatis Zampetakis <zabe...@gmail.com> >> wrote: >>> >>> If I remember well the site preview is not implemented so it is normal >> that >>> links are broken. >>> I don't know if this has changed recently but if not I think we should >>> remove the site preview links from the draft email to avoid confusion. >>> >>> Best, >>> Stamatis >>> >>>> On Mon, Aug 10, 2020 at 8:08 PM Andrei Sereda <and...@sereda.cc> wrote: >>> >>>> Yes I'm aware that for some reason site artifact wasn't built / >> uploaded. >>>> >>>> Meanwhile here are the release notes: >>>> >>>> >> https://github.com/apache/calcite/blob/calcite-1.25.0-rc0/site/_docs/history.md >>>> >>>> I'll double-check the build script / instructions, maybe I have missed >>>> something. >>>> >>>> On Mon, Aug 10, 2020 at 12:59 PM Haisheng Yuan <hy...@apache.org> >> wrote: >>>> >>>>> +1 (binding) >>>>> >>>>> Environment: >>>>> Mac OS X 10.15.1 , JDK 1.8.0_162 >>>>> - Ran unit tests (./gradlew build), OK >>>>> - Checked release notes, CALCITE-4156, CALCITE-4022 CALCITE-4115 >>>>> CALCITE-4129 CALCITE-4111 are not part of Build and test suite changes, >>>>> those can be updated after release. >>>>> >>>>> - Haisheng >>>>> >>>>> On 2020/08/09 03:22:28, Andrei Sereda <and...@sereda.cc> wrote: >>>>>> Hi all, >>>>>> >>>>>> I have created a build for Apache Calcite 1.25.0, release >>>>>> candidate 0. >>>>>> >>>>>> Thanks to everyone who has contributed to this release. >>>>>> >>>>>> You can read the release notes here: >>>>>> https://apache.github.io/calcite-site-preview/docs/history.html >>>>>> >>>>>> The commit to be voted upon: >>>>>> >>>>> >>>> >> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=68b02dfd4af15bc94a91a0cd2a30655d04439555 >>>>>> >>>>>> Its hash is 68b02dfd4af15bc94a91a0cd2a30655d04439555 >>>>>> >>>>>> Tag: >>>>>> https://github.com/apache/calcite/tree/calcite-1.25.0-rc0 >>>>>> >>>>>> The artifacts to be voted on are located here: >>>>>> >>>> >> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.25.0-rc0 >>>>>> (revision 40922) >>>>>> >>>>>> RAT report: >>>>>> https://apache.github.io/calcite-site-preview/rat/rat-report.txt >>>>>> >>>>>> Site preview is here: >>>>>> https://apache.github.io/calcite-site-preview/ >>>>>> >>>>>> JavaDoc API preview is here: >>>>>> https://apache.github.io/calcite-site-preview/api >>>>>> >>>>>> The hashes of the artifacts are as follows: >>>>>> >>>>> >>>> >> a5e61bd93657a274ee8a1d1ecbde68e3e471fd27b85bea179991b372f094ae3cdf692672245506a08b996534f9136be26569de81af2bb7d8f026799313957e87 >>>>>> *apache-calcite-1.25.0-src.tar.gz >>>>>> >>>>>> A staged Maven repository is available for review at: >>>>>> >>>>> >>>> >> https://repository.apache.org/content/repositories/orgapachecalcite-1097/org/apache/calcite/ >>>>>> >>>>>> Release artifacts are signed with the following key: >>>>>> https://people.apache.org/keys/committer/sereda.asc >>>>>> https://www.apache.org/dist/calcite/KEYS >>>>>> >>>>>> N.B. >>>>>> To create the jars and test Apache Calcite: "./gradlew build". >>>>>> >>>>>> If you do not have a Java environment available, you can run the tests >>>>>> using docker. To do so, install docker and docker-compose, then run >>>>>> "docker-compose run test" from the root of the directory. >>>>>> >>>>>> Please vote on releasing this package as Apache Calcite 1.25.0. >>>>>> >>>>>> The vote is open for the next 72 hours and passes if a majority of at >>>>>> least three +1 PMC votes are cast. >>>>>> >>>>>> [ ] +1 Release this package as Apache Calcite 1.25.0 >>>>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release >>>>>> [ ] -1 Do not release this package because... >>>>>> >>>>>> >>>>>> Here is my vote: >>>>>> >>>>>> +1 (non binding) >>>>>> >>>>> >>>> >> >>
