[ 
https://issues.apache.org/jira/browse/FLUME-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502432#comment-13502432
 ] 

Mike Percy commented on FLUME-1713:
-----------------------------------

Rahul, thanks for the patch! In addition to posting to the Apache review board, 
please also:
1. Format your patch using "git diff" instead of "git format-patch".
2. Include a unit test to verify that the functionality works.

                
> Netcat source should allow for *not* returning "OK" upon receipt of each 
> message
> --------------------------------------------------------------------------------
>
>                 Key: FLUME-1713
>                 URL: https://issues.apache.org/jira/browse/FLUME-1713
>             Project: Flume
>          Issue Type: Improvement
>          Components: Easy
>    Affects Versions: v1.2.0
>            Reporter: Mike Percy
>            Priority: Minor
>              Labels: newbie
>         Attachments: 
> 0001-FLUME-1713-Netcat-source-should-allow-for-not-return.patch
>
>
> Right now, the Netcat source returns "OK" when each message is processed. In 
> reality, this means that using netcat to send to the "Netcat source" will in 
> most cases not work as expected. It will stall out if the responses are not 
> read back once the TCP receive buffers fill up.
> The default configuration setup should remain the same though.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to