[
https://issues.apache.org/jira/browse/HIVE-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018683#comment-13018683
]
jirapos...@reviews.apache.org commented on HIVE-2038:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/581/#review428
-----------------------------------------------------------
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
<https://reviews.apache.org/r/581/#comment808>
Please add this property to hive-default.xml along with a description of
what it does.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/581/#comment809>
Please run checkstyle and correct any violations included in your patch.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
<https://reviews.apache.org/r/581/#comment810>
No need to reference "this", right?
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java
<https://reviews.apache.org/r/581/#comment815>
What do you think about changing the name to MetaStoreEventListener or
CatalogEventListener?
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java
<https://reviews.apache.org/r/581/#comment811>
Please add some javadoc explaining the intended use of this interface.
* Are the methods called before or after an action completes? What happens
if a metastore operation fails?
* Are the methods allowed to block? Are they run in a separate thread?
* Are the methods allowed to modify the catalog objects that are passed in
as parameters?
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java
<https://reviews.apache.org/r/581/#comment812>
Checkstyle.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java
<https://reviews.apache.org/r/581/#comment816>
Instead of passing in raw Table/Partition/Database objects it may be better
to instead wrap these objects in containers, e.g. CreateTableEvent,
DropTableEvent, etc. Eventually this interface will probably include
onAlterTable() and onAlterPartition(), and programmers will probably want to
access both the before and after versions of a Table/Partition, etc.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
<https://reviews.apache.org/r/581/#comment813>
Unrelated bugfix?
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java
<https://reviews.apache.org/r/581/#comment814>
Checkstyle.
- Carl
On 2011-04-12 01:29:41, Ashutosh Chauhan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/581/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-12 01:29:41)
bq.
bq.
bq. Review request for hive, Carl Steinbach, John Sichi, and Paul Yang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Review request for HIVE-2038
bq.
bq.
bq. This addresses bug HIVE-2038.
bq. https://issues.apache.org/jira/browse/HIVE-2038
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1079575
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
1079575
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListener.java
PRE-CREATION
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/NoOpListener.java
PRE-CREATION
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
1079575
bq.
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/DummyListener.java
PRE-CREATION
bq.
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreListener.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/581/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit test with dummy listener included. Also tested with an alternate
listener which sends a message on a message bus.
bq.
bq.
bq. Thanks,
bq.
bq. Ashutosh
bq.
bq.
> Metastore listener
> ------------------
>
> Key: HIVE-2038
> URL: https://issues.apache.org/jira/browse/HIVE-2038
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.8.0
>
> Attachments: hive-2038.patch, metastore_listener.patch,
> metastore_listener.patch, metastore_listener.patch
>
>
> Provide to way to observe changes happening on Metastore
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
