----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/558/#review530 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java <https://reviews.apache.org/r/558/#comment1106> Create a followup task for dealing with jobs which access multiple tables. For that, we need to associate the index formats/files with specific tables, and that requires modifying the way the index input format works. ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java <https://reviews.apache.org/r/558/#comment1105> Create a followup task for displaying these in the plan (to indicate that a table scan's input is being filtered by the intermediate file). We only want to do that when they are non-null (to avoid upsetting all the existing test reference files). ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java <https://reviews.apache.org/r/558/#comment1099> spacing ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java <https://reviews.apache.org/r/558/#comment1100> spacing ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java <https://reviews.apache.org/r/558/#comment1102> spacing ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java <https://reviews.apache.org/r/558/#comment1101> When logging errors being propagated, use the two-arg version of the method and pass e as the second arg. Same thing in a few other places. ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java <https://reviews.apache.org/r/558/#comment1103> curly bracket placement ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java <https://reviews.apache.org/r/558/#comment1104> create a followup for this one ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java <https://reviews.apache.org/r/558/#comment1098> This is not an error, just a condition that prevents usage of the index, so it should be logged as info rather than error. - John On 2011-04-22 03:50:54, Russell Melick wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/558/ > ----------------------------------------------------------- > > (Updated 2011-04-22 03:50:54) > > > Review request for hive. > > > Summary > ------- > > Review request for HIVE-1644.12.patch > > > This addresses bug HIVE-1644. > https://issues.apache.org/jira/browse/HIVE-1644 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2cdaeb6 > conf/hive-default.xml 79ea477 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java ca337a8 > ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 69ee03b > ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java c02d90b > ql/src/java/org/apache/hadoop/hive/ql/index/AbstractIndexHandler.java > dd0186d > ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexHandler.java 411b78f > ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexQueryContext.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java > 1f01446 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 50db44c > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java > 6162676 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/IndexWhereResolver.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/PhysicalOptimizer.java > 0ae9fa2 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcCtx.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereProcessor.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/index/IndexWhereTaskDispatcher.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 374e123 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c41bb32 > ql/src/java/org/apache/hadoop/hive/ql/plan/MapredWork.java 73391e9 > ql/src/test/queries/clientpositive/index_auto.q PRE-CREATION > ql/src/test/queries/clientpositive/index_auto_file_format.q PRE-CREATION > ql/src/test/queries/clientpositive/index_auto_multiple.q PRE-CREATION > ql/src/test/queries/clientpositive/index_auto_partitioned.q PRE-CREATION > ql/src/test/queries/clientpositive/index_auto_unused.q PRE-CREATION > ql/src/test/results/clientpositive/index_auto.q.out PRE-CREATION > ql/src/test/results/clientpositive/index_auto_file_format.q.out > PRE-CREATION > ql/src/test/results/clientpositive/index_auto_multiple.q.out PRE-CREATION > ql/src/test/results/clientpositive/index_auto_partitioned.q.out > PRE-CREATION > ql/src/test/results/clientpositive/index_auto_unused.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/558/diff > > > Testing > ------- > > > Thanks, > > Russell > >
