[ https://issues.apache.org/jira/browse/HIVE-4733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689516#comment-13689516 ]
Phabricator commented on HIVE-4733: ----------------------------------- brock has commented on the revision "HIVE-4733 [jira] HiveLockObjectData is not compared properly". One comment about a new exception I saw. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java:456 Looks like we still have an issue with getChildren(). I am able to get get the following exception on trunk. 2013-06-20 13:42:05,313 ERROR ZooKeeperHiveLockManager pool-1-thread-17 (ZooKeeperHiveLockManager.java:unlockPrimitive(465)) - Failed to release ZooKeeper lock: org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode for /hive_zookeeper_namespace/default at org.apache.zookeeper.KeeperException.create(KeeperException.java:111) at org.apache.zookeeper.KeeperException.create(KeeperException.java:51) at org.apache.zookeeper.ZooKeeper.getChildren(ZooKeeper.java:1448) at org.apache.zookeeper.ZooKeeper.getChildren(ZooKeeper.java:1476) at org.apache.hadoop.hive.ql.lockmgr.zookeeper.ZooKeeperHiveLockManager.unlockPrimitive(ZooKeeperHiveLockManager.java:455) REVISION DETAIL https://reviews.facebook.net/D11277 BRANCH HIVE-4733 ARCANIST PROJECT hive To: JIRA, ashutoshc, navis Cc: brock > HiveLockObjectData is not compared properly > ------------------------------------------- > > Key: HIVE-4733 > URL: https://issues.apache.org/jira/browse/HIVE-4733 > Project: Hive > Issue Type: Bug > Components: Locking > Reporter: Navis > Assignee: Navis > Priority: Trivial > Fix For: 0.12.0 > > Attachments: HIVE-4733.D11277.1.patch, HIVE-4733.D11277.2.patch > > > {noformat} > ret = ret && (clientIp == null) ? target.getClientIp() == null : > clientIp.equals(target.getClientIp()); > {noformat} > seemed intended to be > {noformat} > ret = ret && (clientIp == null ? target.getClientIp() == null : > clientIp.equals(target.getClientIp())); > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira