Hi, How to integrate my code into the code base? Which of the following one is the desired approach: 1) confidencesun/jena:JENA-491 -> apache/jena:master 2) confidencesun/jena:JENA-491 -> confidencesun/jena:master -> apache/jena:master 3) confidencesun/jena:JENA-491 -> apache/jena:JENA-491 -> apache/jena:master
regards, Qihong On Tue, Jul 7, 2015 at 1:48 AM, Andy Seaborne <a...@apache.org> wrote: > On 05/07/15 15:49, Qihong Lin wrote: >> >> Hi, >> >> Please check my latest commits [1]. > > > Hi Qihong, > > As in my other message, that has crossed over at the same time you sent > this, it is time to work out the process for delivering to the Jena > codebase. > > Let's start with changes to jena-arq. > > You will need to work with your mentor for this. Please can we have the > discussions regularly on this list. > > It will make integrating the code into the code base much easier - at the > moment, it's quite hard to see how that can be achieved. > > The latest commit has 300+ changed files almost all from merging with Jena > master not your changes. > > I'm afraid that finding the relevant parts to review from such a large > number of files is somewhat difficult. It breaks the github review tools for > a start! > > Andy > > >> I just completed the function of >> QueryEngineHTTP.execConstructQuads(). You can try out the example of >> "query_construct_quad_01()" in TestQuery [2]. >> >> I'll improve the tests later on, with more questions in the other >> thread. Thanks! >> >> Regards, >> Qihong >> >> >> [1] >> https://github.com/confidencesun/jena/commit/07afdbf0fe635d41c302b25a9c51f43802ea903a >> [2] >> https://github.com/confidencesun/jena/blob/JENA-491/jena-fuseki2/jena-fuseki-core/src/test/java/org/apache/jena/fuseki/TestQuery.java >> >> On Sat, Jul 4, 2015 at 10:08 PM, Ying Jiang <jpz6311...@gmail.com> wrote: >>> >>> Hi all, >>> >>> FYI, Google announced the mid-term evaluation result of GSoC 2015 >>> project yesterday. The Jena project of "Extend CONSTRUCT to build >>> quads (JENA-491) passed the evaluation. >>> >>> Hi Qihong, >>> Thanks a lot for your contribution last month! We expect your >>> excellent work in the coming weeks. >>> The status of the project is a little ahead of the schedule. But the >>> rest work is also challenging. You're supposed to integrate JENA-491 >>> into Fuseki. In addition, the tests should be improved in accordance >>> with the original test framework of jena-arq. >>> Have fun! >>> >>> Cheers, >>> Ying Jiang > >
