Hi Andy, Let me clarify PR 89 and PR 91:
PR 89: confidencesun/jena/master -> apache/jena/master confidencesun/jena/master contains the commits of the 1st half part of the project. It only involves jena/arq. PR 91: confidencesun/jena/JENA-491 -> apache/jena/JENA-491-construct-quad confidencesun/jena/JENA-491 contains the commits of 1st and 2nd parts of the project, i.e. that's everything. Because the 2nd part of Fuseki support depends on the 1st part, so I merged confidencesun/jena/master into confidencesun/jena/JENA-491 in the first place, and then added the Fuseki support. ** If confidencesun/jena/JENA-491 contains only the commits of the 2nd part, the java maven projects won't compile. ** If you want to check only the 2nd part, just compare confidencesun/jena/master with confidencesun/jena/JENA-491, like this: https://github.com/confidencesun/jena/compare/master...confidencesun:JENA-491 You can see that, there're 5 changed files, touching both arq and fuseki: In jena-arq (client side of the Fuseki support): QueryEngineHTTP.java ( implement execQuads() and execConstructDataset()) In jena-fuseki-core (sever side): DEF.java, ResponseDataset.java, SPARQL_Query.java, TestQuery.java The implementation of the 2nd part is not complex. I don't see much code that is necessary to be tested. I'll see what I can do with the tests of "different MIME types for the content negotiation". Thanks! Finally, PR 91 contains everything to be merged into apache/jena/master, and PR 89 can be ignored. Or, you can merge PR 89, and then go with PR 91. Hope it's clear. regards, Qihong On Sun, Aug 16, 2015 at 9:14 PM, Andy Seaborne <a...@apache.org> wrote: > Hi - there are some problems with PR 91. > > PR 91 contains changes to jena-arq as well as jena-fuseki-core. Does PR 91 > replace PR 89 or does PR 91 contain some out-of-date update now in PR 89? Or > something else? > > ( > Line 1 of PR 91 as a diff is: > diff --git a/jena-arq/Grammar/arq.jj b/jena-arq/Grammar/arq.jj > ) > > Please produce a PR which is only the changes to fuseki, and should eb > applied after the ARQ changes. > > Also: I can only see one new test in TestQuery.java - I was expecting more > such as using different MIME types for the content negotiation. > > Andy > > > On 15/08/15 10:21, Qihong Lin wrote: >> >> Hi, >> >> Please check my updates of the 3 tasks blow: >> >> 1) jena/arq: in master branch (to be merged first) >> In PR 89, I added some more tests in TestAPI and TS_Script. The bug of >> construct quad projection on exeConstructTriples() has been fixed, >> with the tests of 4 cases (commit 03a321f). >> >> 2) jena/fuseki: in JENA-491 branch >> In PR 91, see commit 0eb28d8. You can try out >> >> org.apache.jena.fuseki.TestQuery.query_construct_01()/query_construct_quad_01() >> >> 3) doc: in jena web page (wiki) >> I can see the staging page [1]. But when I try the "Improve this Page" >> with [1], it redirects me to [2]. I can not find construct_quad.mdtext >> under [2]. I also try to open [3], with "Not Found" error. Could you >> help me please? >> >> regards, >> Qihong >> >> [1] http://jena.staging.apache.org/documentation/query/construct-quad.html >> [2] https://cms.apache.org/jena/wc/edit/anonymous-LWMAVL/trunk/ >> [3] http://jena.apache.org/documentation/query/construct-quad.html > > >
