[
https://issues.apache.org/jira/browse/JENA-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17478757#comment-17478757
]
Andy Seaborne edited comment on JENA-2213 at 1/19/22, 3:18 PM:
---------------------------------------------------------------
bq. jena-geosparql does compile and pass tests without "external" SIS presence.
Not for me.
main fails to compile without {{org.apache.sis.core:sis-referencing}}.
For SIS 1.1, I get {{[ERROR] Tests run: 1110, Failures: 5, Errors: 0, Skipped:
2}}
Without the non-free test dependency, I get {{[ERROR] Tests run: 1110,
Failures: 9, Errors: 171, Skipped: 2}}.
As RM, I can say that special-casing one module is a cost and detracts from
ensuring a smooth build and release.
bq. Going forward we are limited to SIS1.0 in the build.
Bold statement. Why not upgrade and update the tests? To my untrained eye, we
are not merely talking about changes to the calculation - some coordinates are
changing by large amounts.
We can not, over the long term (1 year? 5 years?), remain fixed at 1.0 unless
SIS commit to maintaining that version with fixes and security governance, let
alone all its transitive dependencies.
(I do not see a maintenance branch for 1.0 in their git repo.)
We don't have to makes any changes for Jena 4.4.0 but we have to do something.
The status quo is not sustainable. I do not want it left until it forced on the
project.
[^Diff-SIS-1.1]
Note - also they switched from {{javax.xml}} to {{jakarta.xml}}.
{noformat}
[INFO] +- org.apache.sis.core:sis-referencing:jar:1.0:compile
[INFO] | +- org.apache.sis.core:sis-utility:jar:1.0:compile
[INFO] | +- org.apache.sis.core:sis-metadata:jar:1.0:compile
[INFO] | +- javax.measure:unit-api:jar:1.0:compile
[INFO] | \- org.opengis:geoapi:jar:3.0.1:compile
[INFO] +- org.apache.sis.non-free:sis-embedded-data:jar:1.0:test
[INFO] | \- org.apache.derby:derby:jar:10.14.2.0:test
{noformat}
and
{noformat}
[INFO] +- org.apache.sis.core:sis-referencing:jar:1.1:compile
[INFO] | +- org.apache.sis.core:sis-utility:jar:1.1:compile
[INFO] | +- org.apache.sis.core:sis-metadata:jar:1.1:compile
[INFO] | +- jakarta.xml.bind:jakarta.xml.bind-api:jar:2.3.3:compile
[INFO] | | \- jakarta.activation:jakarta.activation-api:jar:1.2.2:compile
[INFO] | +- javax.measure:unit-api:jar:1.0:compile
[INFO] | \- org.opengis:geoapi:jar:3.0.1:compile
...
[INFO] +- org.apache.sis.non-free:sis-embedded-data:jar:1.1:test
[INFO] | \- org.apache.derby:derby:jar:10.14.2.0:test
{noformat}
was (Author: andy.seaborne):
bq. jena-geosparql does compile and pass tests without "external" SIS presence.
Not for me.
main fails to compile without {{org.apache.sis.core:sis-referencing}}.
For SIS 1.1, I get {{[ERROR] Tests run: 1110, Failures: 5, Errors: 0, Skipped:
2}}
Without the non-free test dependency, I get {{[ERROR] Tests run: 1110,
Failures: 9, Errors: 171, Skipped: 2}}.
As RM, I can say that special-casing one module is a cost and detracts from
ensuring a smooth build and release.
bq. Going forward we are limited to SIS1.0 in the build.
Bold statement. Why not upgrade and update the tests? To my untrained eye, we
are not merely talking about changes to the calculation - some coordinates are
changing by large amounts.
We can not, over the long term (1 year? 5 years?), remain fixed at 1.0 unless
SIS commit to maintaining that version with fixes and security governance, let
alone all its transitive dependencies.
(I do not see a maintenance branch for 1.0 in their git repo.)
We don't have to makes any changes for Jena 4.4.0 but we have to do something.
The status quo is not sustainable. I do not want it left until it forced on the
project.
[^Diff-SIS-1.1]
Note - also they switched from {{javax.xml}} to {{jakarta.xml}}.
{noformat}
[INFO] +- org.apache.sis.core:sis-referencing:jar:1.0:compile
[INFO] | +- org.apache.sis.core:sis-utility:jar:1.0:compile
[INFO] | +- org.apache.sis.core:sis-metadata:jar:1.0:compile
[INFO] | +- javax.measure:unit-api:jar:1.0:compile
[INFO] | \- org.opengis:geoapi:jar:3.0.1:compile
...
[INFO] +- org.apache.sis.non-free:sis-embedded-data:jar:1.0:test
[INFO] | \- org.apache.derby:derby:jar:10.14.2.0:test{noformat}
{noformat}
{noformat}
[INFO] +- org.apache.sis.core:sis-referencing:jar:1.1:compile
[INFO] | +- org.apache.sis.core:sis-utility:jar:1.1:compile
[INFO] | +- org.apache.sis.core:sis-metadata:jar:1.1:compile
[INFO] | +- jakarta.xml.bind:jakarta.xml.bind-api:jar:2.3.3:compile
[INFO] | | \- jakarta.activation:jakarta.activation-api:jar:1.2.2:compile
[INFO] | +- javax.measure:unit-api:jar:1.0:compile
[INFO] | \- org.opengis:geoapi:jar:3.0.1:compile
...
[INFO] +- org.apache.sis.non-free:sis-embedded-data:jar:1.1:test
[INFO] | \- org.apache.derby:derby:jar:10.14.2.0:test
{noformat}
> Jena GeoSPARQL Tests Fail With SIS 1.1
> --------------------------------------
>
> Key: JENA-2213
> URL: https://issues.apache.org/jira/browse/JENA-2213
> Project: Apache Jena
> Issue Type: Test
> Components: GeoSPARQL
> Affects Versions: Jena 4.2.0
> Environment: SIS 1.1
> Reporter: Marco Neumann
> Priority: Minor
> Attachments: Diff-SIS-1.1
>
>
> The Jena automated tests fail after upgrading from SIS 1.0 to SIS 1.1. The
> project members in SIS believe that in SIS 1.1 the "Transverse Mercator"
> projection, whose formulas have been modified in SIS 1.1 for better stability
> may cause this failure.
> {code:java}
> ERROR] Failures:
> [ERROR] SRSInfoTest.testBuildDomainEnvelope_OSGB36:104
> expected:<Env[-118397.00138845091 : 751441.7790901454, -16627.734375018626 :
> 1272149.3463499574]> but was:<Env[-104009.35713717458 : 688806.0073395987,
> -16627.734528041445 : 1256558.4455361878]>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
