Thanks Victoria. Makes sense to me.
On 2/13/23 5:55 PM, Victoria Xia wrote:
Hi everyone,
I have just pushed two minor amendments to KIP-889:
- Updated the versioned store specification to clarify that the *"history
retention" parameter is also used as "grace period,"* which means that
writes (including inserts, updates, and deletes) to the store will not be
accepted if the associated timestamp is older than the store's grace period
(i.e., history retention) relative to the current observed stream time.
- Additional context: previously, the KIP was not explicit about
if/when old writes would no longer be accepted. The reason for
enforcing a
strict grace period after which writes will no longer be accepted is
because otherwise tombstones must be retained indefinitely -- if
the latest
value for a key is a very old tombstone, we would not be able to
expire it
from the store because if there’s an even older non-null put to the store
later, then without the tombstone the store would accept this
write as the
latest value for the key, even though it isn't. In the spirit of
not adding
more to this KIP which has already been accepted, I do not propose to add
additional interfaces to allow users to configure grace period separately
from history retention at this time. Such options can be introduced in a
future KIP in a backwards-compatible way.
- Added a *new method to TopologyTestDriver* for getting a versioned
store: getVersionedKeyValueStore().
- This new method is analogous to existing methods for other types of
stores, and its previous omission from the KIP was an oversight.
If there are no concerns / objections, then perhaps these updates are minor
enough that we can proceed without re-voting.
Happy to discuss,
Victoria
On Wed, Dec 21, 2022 at 8:22 AM Victoria Xia <victoria....@confluent.io>
wrote:
Hi everyone,
We have 3 binding and 1 non-binding vote in favor of this KIP (and no
objections) so KIP-889 is now accepted.
Thanks for voting, and for your excellent comments in the KIP discussion
thread!
Happy holidays,
Victoria
On Tue, Dec 20, 2022 at 12:24 PM Sagar <sagarmeansoc...@gmail.com> wrote:
Hi Victoria,
+1 (non-binding).
Thanks!
Sagar.
On Tue, Dec 20, 2022 at 1:39 PM Bruno Cadonna <cado...@apache.org> wrote:
Hi Victoria,
Thanks for the KIP!
+1 (binding)
Best,
Bruno
On 19.12.22 20:03, Matthias J. Sax wrote:
+1 (binding)
On 12/15/22 1:27 PM, John Roesler wrote:
Thanks for the thorough KIP, Victoria!
I'm +1 (binding)
-John
On 2022/12/15 19:56:21 Victoria Xia wrote:
Hi all,
I'd like to start a vote on KIP-889 for introducing versioned
key-value
state stores to Kafka Streams:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-889%3A+Versioned+State+Stores
The discussion thread has been open for a few weeks now and has
converged
among the current participants.
Thanks,
Victoria
