Hi Andrew, thanks for your comments ! Please see replies inline below.
On Mon, 26 Jun 2023 at 16:51, Andrew Schofield <andrew_schofield_j...@outlook.com> wrote: > 4) For a new interface, I wonder whether it would be better to use > TopicIdPartition rather > than TopicPartition. Topic IDs are gradually spreading across the public > interfaces for Kafka. Thanks for the suggestion, we’ve updated the KIP. > 5) The new topic config is called `record.validation.policy`. The javadoc for > the validationPolicy() > method says `validation.policy`. oops, fixed in the KIP, thx. > 6) I’m surprised that you need a `HeaderProxy` interface when `Headers` and > `Header` are > already interfaces. I would have expected it was possible to create proxy > instances of the > headers using the existing interfaces with a little cunning. A header value() returns a byte[] which can naturally be modified. We introduced the HeaderProxy interface to make it clear that the returned values are read-only, without being forced to make deep copies of byte[]. Thanks, Edo & Adrian
