+1 (non-binding) Thanks for your KIP!
From: dev@kafka.apache.org At: 08/16/23 04:48:13 UTC-4:00To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-953: partition method to be overloaded to accept headers as well. Thanks Sagar and Chris for your votes. I will add the details Chris has asked for to the KIP. Hey everyone, Please consider this as a gentle reminder. On Sat, Aug 12, 2023 at 10:48 AM Chris Egerton <fearthecel...@gmail.com> wrote: > Hi Jack, > > +1 (binding) > > Some friendly, non-blocking suggestions: > > - IMO it's still worth specifying that the headers will be read-only; this > clarifies the intended API contract both for reviewers of the KIP who > haven't read the GitHub PR yet, and for developers who may leverage this > new method > - May be worth mentioning in the compatibility section that any > partitioners that only implement the new interface will be incompatible > with older Kafka clients versions (this is less likely to be a serious > problem in the clients world, but it's a much hairier problem with Connect, > where cross-compatibility between newer/older versions of connectors and > the Kafka Connect runtime is a serious concern) > > Again, these are not blockers and I'm in favor of the KIP with or without > them since I believe both can be addressed at least partially during PR > review and don't have to be tackled at this stage. > > Cheers, > > Chris > > On Sat, Aug 12, 2023 at 12:43 AM Sagar <sagarmeansoc...@gmail.com> wrote: > > > Hey jack , > > > > +1 (non binding) > > > > Sagar. > > > > On Sat, 12 Aug 2023 at 8:04 AM, Jack Tomy <jacktomy...@gmail.com> wrote: > > > > > Hey everyone, > > > > > > Please consider this as a gentle reminder. > > > > > > On Mon, Aug 7, 2023 at 5:55 PM Jack Tomy <jacktomy...@gmail.com> > wrote: > > > > > > > Hey everyone. > > > > > > > > I would like to call for a vote on KIP-953: partition method to be > > > > overloaded to accept headers as well. > > > > > > > > KIP : > > > > > > > > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=263424937 > > > > Discussion thread : > > > > https://lists.apache.org/thread/0f20kvfqkmhdqrwcb8vqgqn80szcrcdd > > > > > > > > Thanks > > > > -- > > > > Best Regards > > > > *Jack* > > > > > > > > > > > > > -- > > > Best Regards > > > *Jack* > > > > > > -- Best Regards *Jack*
