Thank you for the KIP, Nick! This would be highly useful for many reasons. Much more sane than checking for leaked iterators by profiling memory usage while running 100's of thousands of range scans via interactive queries (:
One small question: >The iterator-duration metrics will be updated whenever an Iterator's close() method is called Does the Iterator have its own "createdAt()" or equivalent field, or do we need to keep track of the Iterator's start time upon creation? Cheers, Colt McNealy *Founder, LittleHorse.dev* On Wed, Oct 4, 2023 at 9:07 AM Nick Telford <nick.telf...@gmail.com> wrote: > Hi everyone, > > KIP-989 is a small Kafka Streams KIP to add a few new metrics around the > creation and use of RocksDB Iterators, to aid users in identifying > "Iterator leaks" that could cause applications to leak native memory. > > Let me know what you think! > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-989%3A+RocksDB+Iterator+Metrics > > P.S. I'm not too sure about the formatting of the "New Metrics" table, any > advice there would be appreciated. > > Regards, > Nick >
