Hey Hanyu, Thanks for the KIP, it's a welcomed addition. Overall, the KIP looks good to me, I just have one comment.
Can you discuss the expected behavior when a user executes a timestamped query against a non-timestamped store? I think it should throw an exception vs. using some default value. If it's the case that Kafka Stream wraps all stores in a `TimestampAndValue` store and returning a plain `V` or a `TimestampAndValue<V>` object depends on the query type, then it would be good to add those details to the KIP. Thanks, Bill On Fri, Oct 20, 2023 at 5:07 PM Hanyu (Peter) Zheng <pzh...@confluent.io.invalid> wrote: > Thank you Matthias, > > I will modify the KIP to eliminate this restriction. > > Sincerely, > Hanyu > > On Fri, Oct 20, 2023 at 2:04 PM Hanyu (Peter) Zheng <pzh...@confluent.io> > wrote: > > > Thank you Alieh, > > > > In these two new query types, I will remove 'get' from all getter method > > names. > > > > Sincerely, > > Hanyu > > > > On Fri, Oct 20, 2023 at 10:40 AM Matthias J. Sax <mj...@apache.org> > wrote: > > > >> Thanks for the KIP Hanyu, > >> > >> One questions: > >> > >> > To address this inconsistency, we propose that KeyQuery should be > >> restricted to querying kv-stores only, ensuring that it always returns > a > >> plain V type, making the behavior of the aforementioned code more > >> predictable. Similarly, RangeQuery should be dedicated to querying > >> kv-stores , consistently returning only the plain V . > >> > >> Why do you want to restrict `KeyQuery` and `RangeQuery` to kv-stores? I > >> think it would be possible to still allow both queries for ts-kv-stores, > >> but change the implementation to return "plain V" instead of > >> `ValueAndTimestamp<V>`, ie, the implementation would automatically > >> unwrap the value. > >> > >> > >> > >> -Matthias > >> > >> On 10/20/23 2:32 AM, Alieh Saeedi wrote: > >> > Hey Hanyu, > >> > > >> > Thanks for the KIP. It seems good to me. > >> > Just one point: AFAIK, we are going to remove "get" from the name of > all > >> > getter methods. > >> > > >> > Cheers, > >> > Alieh > >> > > >> > On Thu, Oct 19, 2023 at 5:44 PM Hanyu (Peter) Zheng > >> > <pzh...@confluent.io.invalid> wrote: > >> > > >> >> Hello everyone, > >> >> > >> >> I would like to start the discussion for KIP-992: Proposal to > introduce > >> >> IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery > >> >> > >> >> The KIP can be found here: > >> >> > >> >> > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-992%3A+Proposal+to+introduce+IQv2+Query+Types%3A+TimestampedKeyQuery+and+TimestampedRangeQuery > >> >> > >> >> Any suggestions are more than welcome. > >> >> > >> >> Many thanks, > >> >> Hanyu > >> >> > >> >> On Thu, Oct 19, 2023 at 8:17 AM Hanyu (Peter) Zheng < > >> pzh...@confluent.io> > >> >> wrote: > >> >> > >> >>> > >> >>> > >> >> > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-992%3A+Proposal+to+introduce+IQv2+Query+Types%3A+TimestampedKeyQuery+and+TimestampedRangeQuery > >> >>> > >> >>> -- > >> >>> > >> >>> [image: Confluent] <https://www.confluent.io> > >> >>> Hanyu (Peter) Zheng he/him/his > >> >>> Software Engineer Intern > >> >>> +1 (213) 431-7193 <+1+(213)+431-7193> > >> >>> Follow us: [image: Blog] > >> >>> < > >> >> > >> > https://www.confluent.io/blog?utm_source=footer&utm_medium=email&utm_campaign=ch.email-signature_type.community_content.blog > >> >>> [image: > >> >>> Twitter] <https://twitter.com/ConfluentInc>[image: LinkedIn] > >> >>> <https://www.linkedin.com/in/hanyu-peter-zheng/>[image: Slack] > >> >>> <https://slackpass.io/confluentcommunity>[image: YouTube] > >> >>> <https://youtube.com/confluent> > >> >>> > >> >>> [image: Try Confluent Cloud for Free] > >> >>> < > >> >> > >> > https://www.confluent.io/get-started?utm_campaign=tm.fm-apac_cd.inbound&utm_source=gmail&utm_medium=organic > >> >>> > >> >>> > >> >> > >> >> > >> >> -- > >> >> > >> >> [image: Confluent] <https://www.confluent.io> > >> >> Hanyu (Peter) Zheng he/him/his > >> >> Software Engineer Intern > >> >> +1 (213) 431-7193 <+1+(213)+431-7193> > >> >> Follow us: [image: Blog] > >> >> < > >> >> > >> > https://www.confluent.io/blog?utm_source=footer&utm_medium=email&utm_campaign=ch.email-signature_type.community_content.blog > >> >>> [image: > >> >> Twitter] <https://twitter.com/ConfluentInc>[image: LinkedIn] > >> >> <https://www.linkedin.com/in/hanyu-peter-zheng/>[image: Slack] > >> >> <https://slackpass.io/confluentcommunity>[image: YouTube] > >> >> <https://youtube.com/confluent> > >> >> > >> >> [image: Try Confluent Cloud for Free] > >> >> < > >> >> > >> > https://www.confluent.io/get-started?utm_campaign=tm.fm-apac_cd.inbound&utm_source=gmail&utm_medium=organic > >> >>> > >> >> > >> > > >> > > > > > > -- > > > > [image: Confluent] <https://www.confluent.io> > > Hanyu (Peter) Zheng he/him/his > > Software Engineer Intern > > +1 (213) 431-7193 <+1+(213)+431-7193> > > Follow us: [image: Blog] > > < > https://www.confluent.io/blog?utm_source=footer&utm_medium=email&utm_campaign=ch.email-signature_type.community_content.blog > >[image: > > Twitter] <https://twitter.com/ConfluentInc>[image: LinkedIn] > > <https://www.linkedin.com/in/hanyu-peter-zheng/>[image: Slack] > > <https://slackpass.io/confluentcommunity>[image: YouTube] > > <https://youtube.com/confluent> > > > > [image: Try Confluent Cloud for Free] > > < > https://www.confluent.io/get-started?utm_campaign=tm.fm-apac_cd.inbound&utm_source=gmail&utm_medium=organic > > > > > > > -- > > [image: Confluent] <https://www.confluent.io> > Hanyu (Peter) Zheng he/him/his > Software Engineer Intern > +1 (213) 431-7193 <+1+(213)+431-7193> > Follow us: [image: Blog] > < > https://www.confluent.io/blog?utm_source=footer&utm_medium=email&utm_campaign=ch.email-signature_type.community_content.blog > >[image: > Twitter] <https://twitter.com/ConfluentInc>[image: LinkedIn] > <https://www.linkedin.com/in/hanyu-peter-zheng/>[image: Slack] > <https://slackpass.io/confluentcommunity>[image: YouTube] > <https://youtube.com/confluent> > > [image: Try Confluent Cloud for Free] > < > https://www.confluent.io/get-started?utm_campaign=tm.fm-apac_cd.inbound&utm_source=gmail&utm_medium=organic > > >
