Hi Aaron,
Thanks for publishing this KIP after the feedback on your PR. I'm generally
in favor but have a few questions:
1) Is the consumer mentioned in the KIP the one constructed by the
MirrorSourceConnector for polling replicated records from the source
cluster? If yes, are there any other consumers for which it would also make
sense to disable automatic topic creation?
2) Is broker-side automatic topic creation enabled intentionally in your
source cluster? I know that it is by default but in my experience it's
highly unusual to see it enabled in prod.
3) In that same vein, can you add disabling automatic topic creation
broker-side (setting "auto.create.topics.enable" to "false" in your broker
config(s)) as another rejected alternative? This is useful because it
provides a workaround for users running existing versions of MM2 that don't
have the changes proposed by your KIP.
4) Can you also provide the exact configuration changes that would be
required for the currently-mentioned rejected alternative ("An alternative
solution is to disable this option manually,"), which presumably refers to
altering the configuration of MM2 to manually force the changes to its
consumer(s) that this KIP proposes be applied by default? Again, this is
useful as documentation of a workaround for users running existing versions
of MM2.
Thanks again for the KIP!
Cheers,
Chris
On Fri, Apr 19, 2024 at 6:33 AM aaron ai <aaro...@apache.org> wrote:
> Hi Omnia,
> Thanks for your feedback!
>
> Yes, another approach could be to disable this option manually. IMHO, it's
> hard to envision a scenario where enabling it would be necessary. BTW, I've
> already added this part into the KIP.
>
> On Fri, Apr 19, 2024 at 6:18 PM Omnia Ibrahim <o.g.h.ibra...@gmail.com>
> wrote:
>
> > Hi Aaron,
> > You mentioned that there is no public interface changes however changing
> > the default value of a config should be considered as a public change.
> You
> > can check other KIP where we changed the default config value for a
> > reference.
> >
> > Can you please list what is the impact of changing the behaviour of the
> > topic creation along side as well as is there any rejected alternatives
> > like can’t customer disable allow.auto.create.topics manually for example
> > as a workaround?
> >
> > Thanks
> > Omnia
> >
> > > On 19 Apr 2024, at 10:37, aaron ai <aaro...@apache.org> wrote:
> > >
> > > Hi all,
> > >
> > > Here is the KIP-1039: Disable automatic topic creation for MirrorMaker2
> > > consumers
> > > <
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1039%3A+Disable+automatic+topic+creation+for+MirrorMaker2+consumers
> > >>
> > >
> > > Looking forward to your feedback!
> > >
> > > Best regards,
> > > Aaron
> >
> >
>
