----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26755/#review59679 -----------------------------------------------------------
Ship it! Minor points that I can fix on check-in. core/src/main/scala/kafka/utils/ByteBoundedBlockingQueue.scala <https://reviews.apache.org/r/26755/#comment101009> Unused. i.e, the var can be on line 50 alone core/src/main/scala/kafka/utils/ByteBoundedBlockingQueue.scala <https://reviews.apache.org/r/26755/#comment101010> Will add a comment that this is to avoid the putLock.wait(0, 0) scenario core/src/test/scala/unit/kafka/utils/ByteBoundedBlockingQueueTest.scala <https://reviews.apache.org/r/26755/#comment100971> I think 32-35 can be removed - Joel Koshy On Oct. 29, 2014, 5:57 p.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26755/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2014, 5:57 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1706 > https://issues.apache.org/jira/browse/KAFKA-1706 > > > Repository: kafka > > > Description > ------- > > changed arguments name > > > correct typo. > > > Incorporated Joel's comments. Also fixed negative queue size problem. > > > Incorporated Joel's comments. > > > Added unit test for ByteBoundedBlockingQueue. Fixed a bug regarding wating > time. > > > Diffs > ----- > > core/src/main/scala/kafka/utils/ByteBoundedBlockingQueue.scala PRE-CREATION > core/src/test/scala/unit/kafka/utils/ByteBoundedBlockingQueueTest.scala > PRE-CREATION > > Diff: https://reviews.apache.org/r/26755/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
