----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31591/#review74827 -----------------------------------------------------------
Ship it! LGTM, just a minor comment. core/src/main/scala/kafka/cluster/Partition.scala <https://reviews.apache.org/r/31591/#comment121610> This part seems now serving only logging purpose. If that is the case, can we make it even clearer. For example, print all the acked replicas instead of just a number. - Jiangjie Qin On March 1, 2015, 7:58 a.m., Gwen Shapira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31591/ > ----------------------------------------------------------- > > (Updated March 1, 2015, 7:58 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1992 > https://issues.apache.org/jira/browse/KAFKA-1992 > > > Repository: kafka > > > Description > ------- > > remove unnecessary requiredAcks parameter and clean up few comments > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > c4bf48a801007ebe7497077d2018d6dffe1677d4 > core/src/main/scala/kafka/server/DelayedProduce.scala > 4d763bf05efb24a394662721292fc54d32467969 > > Diff: https://reviews.apache.org/r/31591/diff/ > > > Testing > ------- > > > Thanks, > > Gwen Shapira > >
