> On March 2, 2015, 11:04 p.m., Jiangjie Qin wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java, > > line 219 > > <https://reviews.apache.org/r/29467/diff/4/?file=882250#file882250line219> > > > > We probably need to release the caller threads that are waiting on > > flush() at this point.
Making flush a boolean method that you have to always check to see if someone called close() in another thead would be a really really really painful api to use in practice, right? I think the issue here is actually what I pointed out in the other comment, namely that in-flight requests area actually left incomplete when you call close and hit the forceClose timeout. Any other thread blocking on these futures would block forever. The right solution is just to fail all requests that haven't completed when forceClose kicks in. This then fullfills the criteria for flush which is that all the requests are completed or failed. - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29467/#review74843 ----------------------------------------------------------- On March 2, 2015, 6:41 p.m., Parth Brahmbhatt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29467/ > ----------------------------------------------------------- > > (Updated March 2, 2015, 6:41 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1660 > https://issues.apache.org/jira/browse/KAFKA-1660 > > > Repository: kafka > > > Description > ------- > > Merge remote-tracking branch 'origin/trunk' into KAFKA-1660 > > Conflicts: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java > > Merge remote-tracking branch 'origin/trunk' into KAFKA-1660 > > > Changing log levels as suggested. > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > 7397e565fd865214529ffccadd4222d835ac8110 > clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java > 6913090af03a455452b0b5c3df78f266126b3854 > clients/src/main/java/org/apache/kafka/clients/producer/Producer.java > 5b3e75ed83a940bc922f9eca10d4008d67aa37c9 > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java > ed9c63a6679e3aaf83d19fde19268553a4c107c2 > > Diff: https://reviews.apache.org/r/29467/diff/ > > > Testing > ------- > > existing unit tests passed. > > > Thanks, > > Parth Brahmbhatt > >
