----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review74895 -----------------------------------------------------------
clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java <https://reviews.apache.org/r/31369/#comment121727> Could we add a unit test for Integer Ser/DeSer? clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java <https://reviews.apache.org/r/31369/#comment121724> Incorrect comment. clients/src/main/java/org/apache/kafka/common/serialization/IntegerSerializer.java <https://reviews.apache.org/r/31369/#comment121722> Incorrect comment. examples/src/main/java/kafka/examples/Producer.java <https://reviews.apache.org/r/31369/#comment121726> We should handle the case when metadata is null. - Jun Rao On Feb. 27, 2015, 7:08 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31369/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 7:08 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1982 > https://issues.apache.org/jira/browse/KAFKA-1982 > > > Repository: kafka > > > Description > ------- > > KAFKA-1982: change kafka.examples.Producer to use the new java producer > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/serialization/IntegerSerializer.java > PRE-CREATION > examples/src/main/java/kafka/examples/Consumer.java > 13135b954f3078eeb7394822b0db25470b746f03 > examples/src/main/java/kafka/examples/Producer.java > 96e98933148d07564c1b30ba8e805e2433c2adc8 > > Diff: https://reviews.apache.org/r/31369/diff/ > > > Testing > ------- > > > Thanks, > > Ashish Singh > >
