----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32740/#review78858 -----------------------------------------------------------
Thanks for the new patch. Just a couple of more minor comments. Also, we plan to commit KAFKA-1809 first. Could you rebase after that? clients/src/main/java/org/apache/kafka/common/utils/Utils.java <https://reviews.apache.org/r/32740/#comment127932> It would be useful to add a wrapper method readFileAsString(String path) that uses the default Charset. Then, many callers don't have to pass in null for charset. clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java <https://reviews.apache.org/r/32740/#comment127933> Do we still need to do the casting to byte[]? - Jun Rao On April 2, 2015, 2:16 a.m., Tong Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32740/ > ----------------------------------------------------------- > > (Updated April 2, 2015, 2:16 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1926 > https://issues.apache.org/jira/browse/KAFKA-1926 > > > Repository: kafka > > > Description > ------- > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/common/utils/Utils.java > 920b51a6c3c99639fbc9dc065637eeee3c19fabd > clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java > c899813d55b9c4786adde3d840f040d6645d27c8 > core/src/main/scala/kafka/Kafka.scala > 37de7df059829f40300aa5f920219b869f9c7f78 > core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala > 89fa29a882ae1f2be512e1ae469631c02adeeddb > core/src/main/scala/kafka/admin/PreferredReplicaLeaderElectionCommand.scala > 79b5e0aeb4af77d356f80107685cd9a7d508ef16 > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala > 979992b68af3723cd229845faff81c641123bb88 > core/src/main/scala/kafka/admin/TopicCommand.scala > f400b71f8444fffd3fc1d8398a283682390eba4e > core/src/main/scala/kafka/client/ClientUtils.scala > ebba87f0566684c796c26cb76c64b4640a5ccfde > core/src/main/scala/kafka/cluster/Broker.scala > 0060add008bb3bc4b0092f2173c469fce0120be6 > core/src/main/scala/kafka/cluster/Partition.scala > c4bf48a801007ebe7497077d2018d6dffe1677d4 > core/src/main/scala/kafka/consumer/ConsumerFetcherManager.scala > b9e2bea7b442a19bcebd1b350d39541a8c9dd068 > core/src/main/scala/kafka/consumer/ConsumerIterator.scala > b00a4dca0f3b618e8c6e6b9a1ec99139b3bd76e5 > core/src/main/scala/kafka/consumer/PartitionAssignor.scala > bc2e5b40e29659b8902b65a3234d6b53d8b1aa75 > core/src/main/scala/kafka/consumer/TopicCount.scala > 0954b3c3ff8b3b7a7a4095436bc9e6c494a38c37 > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > b1cf0db8741e384e4e4119751058ea87b2589e57 > core/src/main/scala/kafka/controller/ControllerChannelManager.scala > c582191636f6188c25d62a67ff0315b56f163133 > core/src/main/scala/kafka/controller/KafkaController.scala > 09fc46d759b74bcdad2d2a610d9c5a93ff02423f > core/src/main/scala/kafka/controller/PartitionStateMachine.scala > 2f0694bc5cdfc763f4872d58bec925d0cf919da1 > core/src/main/scala/kafka/controller/ReplicaStateMachine.scala > 3e87e1d36f87b7dd539a474609b1c95487a4c337 > core/src/main/scala/kafka/controller/TopicDeletionManager.scala > e56f22d7399061a72aa67a9ee73ea4d91345c01f > core/src/main/scala/kafka/log/FileMessageSet.scala > b2652ddbe2f857028d5980e29a008b2c614694a3 > core/src/main/scala/kafka/log/Log.scala > 06b8ecc5d11a1acfbaf3c693c42bf3ce5b2cd86d > core/src/main/scala/kafka/log/LogCleanerManager.scala > 351824b3c9fabe0942528147bdde8cee13b63e20 > core/src/main/scala/kafka/log/LogConfig.scala > 8b67aee3a37765178b30d79e9e7bb882bdc89c29 > core/src/main/scala/kafka/log/LogManager.scala > 47d250af62c1aa53d11204a332d0684fb4217c8d > core/src/main/scala/kafka/log/LogSegment.scala > 02567649dd82309011ba2ac6dceda97683e4f5ed > core/src/main/scala/kafka/log/OffsetIndex.scala > ca82c043bb8413b1e010c40de9db1b6dae85e3ac > core/src/main/scala/kafka/log/OffsetMap.scala > 42cdfbb6100b5c89d86144f92f661ebd844b2132 > core/src/main/scala/kafka/message/Message.scala > d3024807a84e104e6a28a29c957f4b964d8dd416 > core/src/main/scala/kafka/message/MessageAndMetadata.scala > d693abc620aef7030f29f915604c5e172d60da0d > core/src/main/scala/kafka/message/MessageWriter.scala > 7eb72cbdc37de55875d8263aae5bb166d977a491 > core/src/main/scala/kafka/metrics/KafkaCSVMetricsReporter.scala > ea9559f822c1120e1997916190fcd597328e4965 > core/src/main/scala/kafka/metrics/KafkaMetricsConfig.scala > 84f6208610e09943e984b54c07b8d287945574f8 > core/src/main/scala/kafka/metrics/KafkaMetricsReporter.scala > 14e46244ee27c8c99f33852cf03bb907cebafa51 > core/src/main/scala/kafka/network/BoundedByteBufferReceive.scala > a44254564531a3fc6008da2be6c1df8bdb75ec75 > core/src/main/scala/kafka/network/SocketServer.scala > 76ce41aed6e04ac5ba88395c4d5008aca17f9a73 > core/src/main/scala/kafka/producer/ByteArrayPartitioner.scala > 6a3b02e414eb7d62cfaece3344245feac54cecda > core/src/main/scala/kafka/producer/DefaultPartitioner.scala > 3afb22eeb4e3b8ecf49e92bd167f2f67b8f6a961 > core/src/main/scala/kafka/producer/Producer.scala > e38d2fa7ec873677cc23b94092ddcd55baf1a3a2 > core/src/main/scala/kafka/producer/ProducerConfig.scala > 3cdf23dce3407f1770b9c6543e3a8ae8ab3ff255 > core/src/main/scala/kafka/producer/async/DefaultEventHandler.scala > 821901e4f434dfd9eec6eceabfc2e1e65507a57c > core/src/main/scala/kafka/server/AbstractFetcherManager.scala > 20c00cb8cc2351950edbc8cb1752905a0c26e79f > core/src/main/scala/kafka/server/AbstractFetcherThread.scala > 5d5cf5897cc37b3595f14bfe9d7cde43456bcc4b > core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala > 0e542ff0cc3eda1cbcef621e73e404c56f092862 > core/src/main/scala/kafka/server/KafkaConfig.scala > 422451aec5ea0442eb2e4c1ae772885b813904a9 > core/src/main/scala/kafka/server/KafkaRequestHandler.scala > 4d86bdf5d146d193858005e7ecadd6e322ca2e20 > core/src/main/scala/kafka/server/KafkaServer.scala > 4db3384545be8c237d6fc9646716ab67d5193ec5 > core/src/main/scala/kafka/server/MetadataCache.scala > 6aef6e4508ecadbbcc1e12bed2054547b7aa333e > core/src/main/scala/kafka/server/OffsetManager.scala > 395b1dbe43a5db47151e72a1b588d72f03cef963 > core/src/main/scala/kafka/server/ZookeeperLeaderElector.scala > a75818a724ff3492f640eec7a57f596324ce6c03 > core/src/main/scala/kafka/tools/ConsoleConsumer.scala > 910691e88ccc66a1542d0ea85bb2f732861d805e > core/src/main/scala/kafka/tools/DumpLogSegments.scala > b7a3630834c8e2c4740e56ac16cc9dfa42554f93 > core/src/main/scala/kafka/tools/KafkaMigrationTool.java > 026d8198678d3e3e41feddcdaa53b67dad5c0e64 > core/src/main/scala/kafka/tools/MirrorMaker.scala > ec077434cac25a10e4f59b9aa569581a2776b2a3 > core/src/main/scala/kafka/tools/SimpleConsumerShell.scala > b4f903b6c7c3bb725cac7c05eb1f885906413c4d > core/src/main/scala/kafka/tools/StateChangeLogMerger.scala > b34b8c7d7d4caaab230719a67048310e0fbb3280 > core/src/main/scala/kafka/tools/TestEndToEndLatency.scala > 48cff20e760a9797ad64ef2a5a28e07e2951f096 > core/src/main/scala/kafka/tools/TestLogCleaning.scala > af496f7c547a5ac7a4096a6af325dad0d8feec6f > core/src/main/scala/kafka/tools/UpdateOffsetsInZK.scala > 111c9a8b94ce45d95551482e9fd3f8c1cccbf548 > core/src/main/scala/kafka/utils/CoreUtils.scala PRE-CREATION > core/src/main/scala/kafka/utils/Crc32.java > 0e0e7bcb33886f47b9770a122d00d6eafdbb89a9 > core/src/main/scala/kafka/utils/KafkaScheduler.scala > 7ceadccefe8206440ab1218a0e7cc36f1307e85a > core/src/main/scala/kafka/utils/Log4jController.scala > a015c8109f050cabdea988f2215bd01ec0d8573a > core/src/main/scala/kafka/utils/Logging.scala > 2890e7f51ddcb056672b30047b7b1df84a5b8df9 > core/src/main/scala/kafka/utils/Utils.scala > 738c1af9ef5de16fdf5130daab69757a14c48b5c > core/src/main/scala/kafka/utils/VerifiableProperties.scala > 2ffc7f452dc7a1b6a06ca7a509ed49e1ab3d1e68 > core/src/test/scala/integration/kafka/api/ProducerCompressionTest.scala > cae72f4f87f10b843c29dc731c6e0028b1d50734 > core/src/test/scala/kafka/tools/TestEndToEndLatency.scala PRE-CREATION > core/src/test/scala/kafka/tools/TestLogCleaning.scala PRE-CREATION > core/src/test/scala/other/kafka/DeleteZKPath.scala > 25545037517b127911cedc39419194535a75be8a > core/src/test/scala/other/kafka/StressTestLog.scala > e19b8b28383554512a0c1f651d6764650d8db9c4 > core/src/test/scala/other/kafka/TestCrcPerformance.scala > 42e3c62055c1562d3a1cee4c8374ae2559a55be7 > core/src/test/scala/other/kafka/TestLinearWriteSpeed.scala > 7211c2529c1db76100432737da7a1d1d221dfba0 > core/src/test/scala/unit/kafka/admin/AddPartitionsTest.scala > 8bc178505e00932a316c46ed1d904bd57b5b3f75 > core/src/test/scala/unit/kafka/admin/AdminTest.scala > ee0b21e6a94ad79c11dd08f6e5adf98c333e2ec9 > core/src/test/scala/unit/kafka/consumer/ConsumerIteratorTest.scala > 995397ba2e2dfc6fadd9d5c5efd90f2c4ac0d59c > core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala > 062790f15d4ab6e0ee7a98bef12aaa2b22da3bfa > core/src/test/scala/unit/kafka/integration/PrimitiveApiTest.scala > 30deaf47b64592f2e1cc84a4156671fac11b67ef > core/src/test/scala/unit/kafka/integration/RollingBounceTest.scala > 4d27e41c727e73544b2b214a0a0b60f6acdbfd17 > core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala > 8342cae564ebc39fe74a512343a4523072ca205a > core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala > fa4a8ad0acc9e8eca8f2e035ec7fe9bb24d8589a > core/src/test/scala/unit/kafka/log/CleanerTest.scala > a4da95f765e5778c896551ecef0e0eaef5167ae1 > core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala > 07acd460b1259e0a3f4069b8b8dcd8123ef5810e > core/src/test/scala/unit/kafka/log/LogManagerTest.scala > 90cd53033fafaf952ba0b3f1e28b0e1f1ad3ea76 > core/src/test/scala/unit/kafka/log/LogTest.scala > 3c0599cc2ea12566fbec8233e3a73b31854b3b38 > core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala > 36db9172ea2d4d7e242e023ba914596c1f64f5f4 > core/src/test/scala/unit/kafka/message/MessageTest.scala > 7b74a0d31547074ef4ed0f95e5b347b2007c6eaf > core/src/test/scala/unit/kafka/producer/AsyncProducerTest.scala > be90c5bc7f1f5ba8a237d1c7176f27029727c918 > core/src/test/scala/unit/kafka/producer/ProducerTest.scala > d2f3851cb68ff595bbb859d27b3552e751d060bb > core/src/test/scala/unit/kafka/server/AdvertiseBrokerTest.scala > 296e2b563041318d360db4037411879613a63968 > core/src/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala > 0bdbc2f31fcac2abdeff4e41e448a7b9ab13b95b > core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala > f2528059dd86bb051d1ce9d72039cde3b78b8817 > core/src/test/scala/unit/kafka/server/LogOffsetTest.scala > 8c9f9e748e888da6035755c9f4241ac3aa0500c9 > core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala > 92d6b2c672f74cdd526f2e98da8f7fb3696a88e3 > core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala > 7654275c5437e1db319f01a8d587d66b42ea8dc7 > core/src/test/scala/unit/kafka/server/ServerGenerateBrokerIdTest.scala > 96a8a5a8cb1f40f743490f85bf18d441ce86a765 > core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala > 71317eb46b8d76060b115e6c1d31a4653459724f > core/src/test/scala/unit/kafka/server/ServerStartupTest.scala > 60021ef8d8d7fa172d6b160db48ee5eb9574e1a9 > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 1682a77362123449de6bb1d54a55887409990a24 > core/src/test/scala/unit/kafka/utils/UtilsTest.scala > 8c3797a964a2760a00ed60530d1a48e3da473769 > core/src/test/scala/unit/kafka/zk/EmbeddedZookeeper.scala > 31515615089385c722325bfe019a47ae3a9a4052 > core/src/test/scala/unit/kafka/zk/ZooKeeperTestHarness.scala > 67d9c4bab270c852dc05d47aaa4dd96b0f6039d4 > > Diff: https://reviews.apache.org/r/32740/diff/ > > > Testing > ------- > > > Thanks, > > Tong Li > >
