[ https://issues.apache.org/jira/browse/LUCENE-8334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492502#comment-16492502 ]
Dawid Weiss commented on LUCENE-8334: ------------------------------------- Yeah... I look as much as my time permits, which isn't too much. :( What you mention is actually what we do: I wrongly thought you removed the public qualifier from the class (as well as the constructor); looking at the diff only confused me. LGTM! > Ensure SR#getSementInfo() returns snapshot > ------------------------------------------ > > Key: LUCENE-8334 > URL: https://issues.apache.org/jira/browse/LUCENE-8334 > Project: Lucene - Core > Issue Type: Bug > Reporter: Simon Willnauer > Priority: Major > Attachments: LUCENE-8334.patch > > > The SegmentCommitInfo passed to the segment reader is mutated concurrently. > An instance obtained from SR#getSegmentInfo() might return wrong delete > counts > or generation ids. This ensures that the SR will use a clone internally > while stil > maintaining the original SI since it's needed inside IW for maintainance > like > accessing pooled readers etc. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org