[ 
https://issues.apache.org/jira/browse/LUCENE-8600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718992#comment-16718992
 ] 

Simon Willnauer commented on LUCENE-8600:
-----------------------------------------

to be honest I am not very much concerned about this causing OOMs. In the worst 
case we would use 4 byte per ord x the number of updates in the package that 
means we need about 300k updates to consume ~1MB of RAM here. I think that is 
an unlikely scenario. Additionally this is transient memory so I thin we are 
good here [~dweiss] 

+1 to the patch from my side

> DocValuesFieldUpdates should use a better sort
> ----------------------------------------------
>
>                 Key: LUCENE-8600
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8600
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-8600.patch
>
>
> This is a follow-up to LUCENE-8598: Simon identified that swaps are a 
> bottleneck to applying doc-value updates, in particular due to the overhead 
> of packed ints. It turns out that InPlaceMergeSorter does LOTS of swaps in 
> order to perform in-place. Replacing with a more efficient sort should help.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to