[ 
https://issues.apache.org/jira/browse/SOLR-12368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878866#comment-16878866
 ] 

Adrien Grand commented on SOLR-12368:
-------------------------------------

I'm not familiar enough with how Solr routes updates to doc values or stored 
fields, but indeed we don't need to avoid updates on fields that don't exist 
anymore. Thanks for cleaning this up! Can you mark IndexWriter#getFieldNames as 
deprecated on 8.x instead of removing (which is the right thing to do on 
master).

> in-place DV updates should no longer have to jump through hoops if field does 
> not yet exist
> -------------------------------------------------------------------------------------------
>
>                 Key: SOLR-12368
>                 URL: https://issues.apache.org/jira/browse/SOLR-12368
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>            Priority: Major
>         Attachments: SOLR-12368.patch, SOLR-12368.patch, SOLR-12368.patch
>
>
> When SOLR-5944 first added "in-place" DocValue updates to Solr, one of the 
> edge cases thta had to be dealt with was the limitation imposed by 
> IndexWriter that docValues could only be updated if they already existed - if 
> a shard did not yet have a document w/a value in the field where the update 
> was attempted, we would get an error.
> LUCENE-8316 seems to have removed this error, which i believe means we can 
> simplify & speed up some of the checks in Solr, and support this situation as 
> well, rather then falling back on full "read stored fields & reindex" atomic 
> update



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to