[
https://issues.apache.org/jira/browse/LUCENE-8956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand reopened LUCENE-8956:
----------------------------------
I had to revert this change due to test failures such as
{noformat}
13:40:13 [junit4] Suite: org.apache.lucene.search.TestQueryRescorer
13:40:13 [junit4] 2> NOTE: reproduce with: ant test
-Dtestcase=TestQueryRescorer -Dtests.method=testRescoreIsIdempotent
-Dtests.seed=2E252C4ACD6D510E -Dtests.slow=true -Dtests.badapples=true
-Dtests.locale=nb -Dtests.timezone=America/Indiana/Winamac -Dtests.asserts=true
-Dtests.file.encoding=UTF8
13:40:13 [junit4] FAILURE 0.04s J3 |
TestQueryRescorer.testRescoreIsIdempotent <<<
13:40:13 [junit4] > Throwable #1: junit.framework.AssertionFailedError:
Hit 3 docnumbers don't match
13:40:13 [junit4] > Hits length1=30 length2=30
13:40:13 [junit4] > hit=0: doc11=0.027509231 shardIndex=-1,
doc11=0.027509231 shardIndex=-1
13:40:13 [junit4] > hit=1: doc59=0.026626626 shardIndex=-1,
doc59=0.026626626 shardIndex=-1
13:40:13 [junit4] > hit=2: doc94=0.025820786 shardIndex=-1,
doc94=0.025820786 shardIndex=-1
13:40:13 [junit4] > hit=3: doc14=0.025403785 shardIndex=-1,
doc13=0.025586303 shardIndex=-1
13:40:13 [junit4] > hit=4: doc13=0.025586303 shardIndex=-1,
doc14=0.025403785 shardIndex=-1
13:40:13 [junit4] > hit=5: doc69=0.02535518 shardIndex=-1,
doc69=0.02535518 shardIndex=-1
13:40:13 [junit4] > hit=6: doc37=0.024901403 shardIndex=-1,
doc37=0.024901403 shardIndex=-1
13:40:13 [junit4] > hit=7: doc73=0.023868036 shardIndex=-1,
doc73=0.023868036 shardIndex=-1
13:40:13 [junit4] > hit=8: doc63=0.021619176 shardIndex=-1,
doc63=0.021619176 shardIndex=-1
13:40:13 [junit4] > hit=9: doc72=0.019876242 shardIndex=-1,
doc72=0.019876242 shardIndex=-1
13:40:13 [junit4] > hit=10: doc50=0.01923588 shardIndex=-1,
doc50=0.01923588 shardIndex=-1
13:40:13 [junit4] > hit=11: doc10=0.018147592 shardIndex=-1,
doc10=0.018147592 shardIndex=-1
13:40:13 [junit4] > hit=12: doc0=0.018087288 shardIndex=-1,
doc0=0.018087288 shardIndex=-1
13:40:13 [junit4] > hit=13: doc98=0.017422743 shardIndex=-1,
doc98=0.017422743 shardIndex=-1
13:40:13 [junit4] > hit=14: doc47=0.016934035 shardIndex=-1,
doc47=0.016934035 shardIndex=-1
13:40:13 [junit4] > hit=15: doc6=0.016177062 shardIndex=-1,
doc79=0.016415473 shardIndex=-1
13:40:13 [junit4] > hit=16: doc96=0.016177062 shardIndex=-1,
doc6=0.016177062 shardIndex=-1
13:40:13 [junit4] > hit=17: doc79=0.016415473 shardIndex=-1,
doc96=0.016177062 shardIndex=-1
13:40:13 [junit4] > hit=18: doc55=0.015521079 shardIndex=-1,
doc55=0.015521079 shardIndex=-1
13:40:13 [junit4] > hit=19: doc34=0.011353219 shardIndex=-1,
doc34=0.011353219 shardIndex=-1
13:40:13 [junit4] > hit=20: doc9=0.010401427 shardIndex=-1,
doc9=0.010401427 shardIndex=-1
13:40:13 [junit4] > hit=21: doc12=0.0033432373 shardIndex=-1,
doc12=0.0033432373 shardIndex=-1
13:40:13 [junit4] > hit=22: doc15=0.0033432373 shardIndex=-1,
doc15=0.0033432373 shardIndex=-1
13:40:13 [junit4] > hit=23: doc23=0.0033432373 shardIndex=-1,
doc23=0.0033432373 shardIndex=-1
13:40:13 [junit4] > hit=24: doc26=0.0033432373 shardIndex=-1,
doc26=0.0033432373 shardIndex=-1
13:40:13 [junit4] > hit=25: doc31=0.0033432373 shardIndex=-1,
doc31=0.0033432373 shardIndex=-1
13:40:13 [junit4] > hit=26: doc33=0.0033432373 shardIndex=-1,
doc33=0.0033432373 shardIndex=-1
13:40:13 [junit4] > hit=27: doc41=0.0033432373 shardIndex=-1,
doc41=0.0033432373 shardIndex=-1
13:40:13 [junit4] > hit=28: doc43=0.0033432373 shardIndex=-1,
doc43=0.0033432373 shardIndex=-1
13:40:13 [junit4] > hit=29: doc45=0.0033432373 shardIndex=-1,
doc45=0.0033432373 shardIndex=-1
13:40:13 [junit4] > for query:field:"river river"~1
13:40:13 [junit4] > at
__randomizedtesting.SeedInfo.seed([2E252C4ACD6D510E:E4C37C59CD79ADE6]:0)
13:40:13 [junit4] > at junit.framework.Assert.fail(Assert.java:57)
13:40:13 [junit4] > at
org.apache.lucene.search.CheckHits.checkEqual(CheckHits.java:205)
13:40:13 [junit4] > at
org.apache.lucene.search.TestQueryRescorer.testRescoreIsIdempotent(TestQueryRescorer.java:142)
13:40:13 [junit4] > at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
13:40:13 [junit4] > at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
13:40:13 [junit4] > at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
13:40:13 [junit4] > at
java.base/java.lang.reflect.Method.invoke(Method.java:566)
13:40:13 [junit4] > at
java.base/java.lang.Thread.run(Thread.java:834)
{noformat}
[~pcsanwald] told me he is looking into it.
> QueryRescorer sort optimization
> -------------------------------
>
> Key: LUCENE-8956
> URL: https://issues.apache.org/jira/browse/LUCENE-8956
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/query/scoring
> Reporter: Paul Sanwald
> Priority: Minor
> Fix For: 8.3
>
> Attachments: LUCENE-8956.patch
>
>
> This patch addresses a TODO in QueryRescorer: We should not sort the full
> array of the results returned from rescoring, but rather only topN, when topN
> is less than total hits.
>
> Made this optimization with some suggestions from [~jpountz] and [~jimczi],
> this is my first lucene patch submission.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
