"dev" <dev-boun...@openvswitch.org> wrote on 07/19/2016 04:15:56 PM:
> From: Justin Pettit <jpet...@ovn.org> > To: Hui Kang <hkang.sun...@gmail.com> > Cc: dev@openvswitch.org > Date: 07/19/2016 04:16 PM > Subject: Re: [ovs-dev] [PATCH v3] [OVN-northd] Rename nbs/nbr port > names to nbsp/nbrp > Sent by: "dev" <dev-boun...@openvswitch.org> > > > > On Jul 19, 2016, at 11:36 AM, Hui Kang <hkang.sun...@gmail.com> wrote: > > > > These variables indicate ports in nb switches or routers. > > > > Signed-off-by: Hui Kang <ka...@us.ibm.com> > > > > -- > > v2->v3: > > - rebase agains master branch > > v1->v2: > > - modify commit message > > --- > > Thanks for the patch. Just a few things first, though: > > - A couple of lines you changed went over 80 columns. I'll wrap those. > - The way you wrote your revision history, it shows up in the > commit message. I'll fix it up. > - Your author email address and Signed-off-by don't match. Which > do you want to use? I'd like to use the corporate email account, which is ka...@us.ibm.com I will figure out how to setup the mail account in my dev box and keep them consistent next time. Thanks for your help. - Hui > > I'll merge it after I get clarification on that last question. > > --Justin > > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev