On Thu, Jul 28, 2016 at 02:18:45PM +0000, Ryan Moats wrote: > With incremental processing of logical flows desired conntrack groups > are not being persisted. This patch adds this capability, with the > side effect of adding a ds_clone method that this capability leverages. > > Signed-off-by: Ryan Moats <rmo...@us.ibm.com> > Reported-by: Guru Shetty <g...@ovn.org> > Reported-at: http://openvswitch.org/pipermail/dev/2016-July/076320.html > Fixes: 70c7cfe ("ovn-controller: Add incremental processing to lflow_run and > physical_run") > --- > v1->v2 addressed review comments > updated commit message > changed name of ds_copy to ds_clone > moved lflow uuid storage to action_params for cleaner code
It seems odd that group_clone() doesn't copy the UUID. I'm not sure why group_info's 'group' member is a struct ds instead of just a char *. (This isn't anything that you introduced.) Coding style: > +static struct group_info * > +group_info_clone(struct group_info *source) { But I'll hold off on further review since Guru reports that this causes test failures in the system tests. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev