RC seems fine except: * I still hit the failing test because of a locale problem (fixed in master). Switching to en_US helps. No blocker for the release. * Also triggering the maven-remote-resource-plugin issue. I've run the tests on OSX, not sure if that could be the difference. (Apache Maven 3.3.9, Java 1.8.0_112)
On Mon, Jan 23, 2017, at 10:38 PM, Cheng Lian wrote: > PS: The testing Spark branch can be found here > https://github.com/apache/spark/compare/4a11d029dc6abeb98fef5725d3d446a3eb5deddf...liancheng:try-parquet-1.8.2-rc1 > > > On 1/23/17 1:36 PM, Cheng Lian wrote: > > > > +1 if the maven-remote-resource-plugin issue is irrelevant. > > > > Checks performed: > > > > * Checked sums > > * Built and installed parquet-mr 1.8.2-rc1 locally. > > * Built a Spark branch based on the current master > > > > <https://github.com/apache/spark/commit/4a11d029dc6abeb98fef5725d3d446a3eb5deddf> > > that upgrades parquet-mr to 1.8.2-rc1 and ran related tests locally. > > > > Cheng > > > > > > On 1/23/17 12:59 PM, Cheng Lian wrote: > >> > >> One thing I hit is that I have to add > >> > >> |<plugin> <groupId>org.apache.maven.plugins</groupId> > >> <artifactId>maven-remote-resources-plugin</artifactId> > >> <version>1.5</version> <configuration> <skip>true</skip> > >> </configuration> </plugin> | > >> > >> in pom.xml to build parquet-mr 1.8.2-rc1. Otherwise I consistently hit: > >> > >> [ERROR] Failed to execute goal > >> org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process > >> (default) on project parquet-generator: Error rendering velocity > >> resource. NullPointerException -> [Help 1] > >> > >> which should be a known issue caused by the maven-filtering plugin (a > >> transitive dependency of maven-remote-resources-plugin). > >> > >> I copied the above snippet from the pom.xml in 1.9.0. Considering > >> other people built the release just fine, did I miss something here? > >> > >> Cheng > >> > >> On 1/23/17 12:33 PM, Julien Le Dem wrote: > >> > >>> Thank you Cheng! > >>> > >>> On Mon, Jan 23, 2017 at 12:02 PM, Cheng Lian <lian.cs....@gmail.com > >>> <mailto:lian.cs....@gmail.com>> wrote: > >>> > >>> Sorry for being late, I'm building a Spark branch based on the > >>> most recent master to test out 1.8.2-rc1, will post my result > >>> here ASAP. > >>> > >>> Cheng > >>> > >>> > >>> On 1/23/17 11:43 AM, Julien Le Dem wrote: > >>>> Hi Spark dev, > >>>> Here is the voting thread for parquet 1.8.2 release. > >>>> Cheng or someone else we would appreciate you verify it as well > >>>> and reply to the thread. > >>>> > >>>> On Mon, Jan 23, 2017 at 11:40 AM, Julien Le Dem > >>>> <jul...@dremio.com <mailto:jul...@dremio.com>> wrote: > >>>> > >>>> +1 > >>>> Followed: > >>>> > >>>> https://cwiki.apache.org/confluence/display/PARQUET/How+To+Verify+A+Release > >>>> > >>>> <https://cwiki.apache.org/confluence/display/PARQUET/How+To+Verify+A+Release> > >>>> checked sums, ran the build and tests. > >>>> We would appreciate someone from the Spark project (Cheng?) > >>>> to verify the release as well. > >>>> CC'ing spark > >>>> > >>>> > >>>> On Mon, Jan 23, 2017 at 10:15 AM, Ryan Blue > >>>> <rb...@netflix.com.invalid > >>>> <mailto:rb...@netflix.com.invalid>> wrote: > >>>> > >>>> +1 > >>>> > >>>> On Mon, Jan 23, 2017 at 10:15 AM, Daniel Weeks > >>>> <dwe...@netflix.com.invalid> > >>>> <mailto:dwe...@netflix.com.invalid> > >>>> wrote: > >>>> > >>>> > +1 checked sums, built, tested > >>>> > > >>>> > On Mon, Jan 23, 2017 at 9:58 AM, Ryan Blue > >>>> <rb...@netflix.com.invalid> > >>>> <mailto:rb...@netflix.com.invalid> > >>>> > wrote: > >>>> > > >>>> > > Gabor, that md5 matches what I get. Are you sure > >>>> you used the right file? > >>>> > > It isn’t the same format that md5sum produces, but > >>>> if you check the > >>>> > octets > >>>> > > the hash matches.. > >>>> > > > >>>> > > [blue@work Downloads]$ md5sum > >>>> apache-parquet-1.8.2.tar.gz > >>>> > > b3743995bee616118c28f324598684ba > >>>> apache-parquet-1.8.2.tar.gz > >>>> > > > >>>> > > rb > >>>> > > > >>>> > > > >>>> > > On Thu, Jan 19, 2017 at 8:06 AM, Gabor Szadovszky < > >>>> > > gabor.szadovs...@cloudera.com > >>>> <mailto:gabor.szadovs...@cloudera.com>> wrote: > >>>> > > > >>>> > > > Hi Ryan, > >>>> > > > > >>>> > > > I’ve downloaded the tar and checked the signature > >>>> and the checksums. > >>>> > SHA > >>>> > > > and ASC are fine. MD5 is not and the content does > >>>> not seem to be a > >>>> > common > >>>> > > > MD5 either: > >>>> > > > apache-parquet-1.8.2.tar.gz: B3 74 39 95 BE E6 16 > >>>> 11 8C 28 F3 24 59 86 > >>>> > > 84 > >>>> > > > BA > >>>> > > > > >>>> > > > The artifacts on Nexus are good with all the > >>>> related signatures and > >>>> > > > checksums. The source zip properly contains the > >>>> files from the repo > >>>> > with > >>>> > > > the tag apache-parquet-1.8.2. > >>>> > > > > >>>> > > > Regards, > >>>> > > > Gabor > >>>> > > > > >>>> > > > > On 19 Jan 2017, at 04:09, Ryan Blue > >>>> <b...@apache.org <mailto:b...@apache.org>> wrote: > >>>> > > > > > >>>> > > > > Hi everyone, > >>>> > > > > > >>>> > > > > I propose the following RC to be released as > >>>> official Apache Parquet > >>>> > > > 1.8.2 > >>>> > > > > release. > >>>> > > > > > >>>> > > > > The commit id is > >>>> c6522788629e590a53eb79874b95f6c3ff11f16c > >>>> > > > > * This corresponds to the tag: apache-parquet-1.8.2 > >>>> > > > > * > >>>> https://github.com/apache/parquet-mr/tree/c6522788 > >>>> <https://github.com/apache/parquet-mr/tree/c6522788> > >>>> > > > > * > >>>> > > > > > >>>> https://git-wip-us.apache.org/repos/asf/projects/repo?p= > >>>> <https://git-wip-us.apache.org/repos/asf/projects/repo?p=> > >>>> > > > parquet-mr.git&a=commit&h=c6522788 > >>>> > > > > > >>>> > > > > The release tarball, signature, and checksums > >>>> are here: > >>>> > > > > * > >>>> https://dist.apache.org/repos/dist/dev/parquet/apache- > >>>> <https://dist.apache.org/repos/dist/dev/parquet/apache-> > >>>> > > > parquet-1.8.2-rc1 > >>>> > > > > > >>>> > > > > You can find the KEYS file here: > >>>> > > > > * > >>>> https://dist.apache.org/repos/dist/dev/parquet/KEYS > >>>> <https://dist.apache.org/repos/dist/dev/parquet/KEYS> > >>>> > > > > > >>>> > > > > Binary artifacts are staged in Nexus here: > >>>> > > > > * > >>>> > > > > > >>>> https://repository.apache.org/content/groups/staging/org/ > >>>> <https://repository.apache.org/content/groups/staging/org/> > >>>> > > > apache/parquet/parquet/1.8.2/ > >>>> > > > > > >>>> > > > > This is a patch release with backports from the > >>>> master branch. For a > >>>> > > > > detailed summary, see the spreadsheet here: > >>>> > > > > > >>>> > > > > * > >>>> > > > > > >>>> https://docs.google.com/spreadsheets/d/1NAuY3c77Egs6REu- > >>>> <https://docs.google.com/spreadsheets/d/1NAuY3c77Egs6REu-> > >>>> > > > UVkQqPswpVYVgZTTnY3bM0SPVRs/edit#gid=0 > >>>> > > > > > >>>> > > > > Please download, verify, and test. > >>>> > > > > > >>>> > > > > Please vote by the end of Monday, 18 January. > >>>> > > > > > >>>> > > > > [ ] +1 Release this as Apache Parquet 1.8.2 > >>>> > > > > [ ] +0 > >>>> > > > > [ ] -1 Do not release this because... > >>>> > > > > > >>>> > > > > > >>>> > > > > > >>>> > > > > -- > >>>> > > > > Ryan Blue > >>>> > > > > >>>> > > > > >>>> > > > >>>> > > > >>>> > > -- > >>>> > > Ryan Blue > >>>> > > Software Engineer > >>>> > > Netflix > >>>> > > > >>>> > > >>>> > >>>> > >>>> > >>>> -- > >>>> Ryan Blue > >>>> Software Engineer > >>>> Netflix > >>>> > >>>> > >>>> > >>>> > >>>> -- > >>>> Julien > >>>> > >>>> > >>>> > >>>> > >>>> -- > >>>> Julien > >>> > >>> > >>> > >>> > >>> -- > >>> Julien > >> > > >
