(Because I accidentally sent just to Istvan the first time)
On 11/19/20 3:27 PM, Josh Elser wrote:
+1 binding
* NOTICE has out of date copyright year. Fix for later. License appears
fine (some copyright retained by Yahoo on some benchmark files, it
seems, but still apache licensed)
* xsums/sigs OK
* Some errors reported by `mvn apache-rat:check`. Fine to ship in this,
IMO. Let's get fixed for next release.
```
misc/findbugs-exclude.xml
misc/omid_checks.xml
bintray-settings.xml
doc/images/ModuleDependencies.graffle
doc/site/site.xml
.travis.yml
```
* Can run unit tests
* Can build Phoenix's master branch with 1.0.2rc0 (have to use the
profile `-Phbase-2` on phoenix-omid when building). A smell we can fix
later in omid.
* Phoenix unit tests pass with 1.0.2rc0
Looks great to me by that! Nice work, Istvan.
- Josh
On 11/17/20 10:24 AM, Istvan Toth wrote:
Please vote on this Apache phoenix omid release candidate,
phoenix-omid-1.0.2RC0
The VOTE will remain open for at least 72 hours.
[ ] +1 Release this package as Apache phoenix omid 1.0.2
[ ] -1 Do not release this package because ...
The tag to be voted on is 1.0.2RC0:
https://github.com/apache/phoenix-omid/tree/1.0.2RC0
The release files, including signatures, digests, as well as CHANGES.md
and RELEASENOTES.md included in this RC can be found at:
https://dist.apache.org/repos/dist/dev/phoenix/phoenix-omid-1.0.2RC0/
Maven artifacts are available in a staging repository at:
https://repository.apache.org/content/repositories/orgapachephoenix-1203/
Artifacts were signed with the 0x794433C7 key which can be found in:
https://dist.apache.org/repos/dist/release/phoenix/KEYS
To learn more about Apache phoenix omid, please see
https://omid.incubator.apache.org/
Thanks,
Istvan
