+1 Great
On Fri, May 21, 2021 at 12:49 AM Jia Yu <ji...@apache.org> wrote: > Hi Felix, > > Thanks for your time! > > 1. Actually the build instruction is already in the source.tar.gz because > the build instruction is by default delivered together with the source > code. And it is also git tagged together with the source code. Please see > 1.0.1-rc1 git tag: > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/docs/download/compile.md > > 2. All java artifacts had been staged on ASF maven repo when I created this > vote email. > > 3. docs/archive is for the old GeoSpark docs. We keep it in the doc website > for users who are still using GeoSpark, instead of Sedona. The generated > docs are put here: http://sedona.apache.org/archive/download/overview/ > > Thanks, > Jia > > > On Thu, May 20, 2021 at 10:50 AM Felix Cheung <felixche...@apache.org> > wrote: > > > 1. You probably shouldn't put .md doc on release share - if I understand > > the suggestion is to include it into the src.tar.gz (and into the source > > repo) so that they are git tagged and packaged together > > > > 2. Do you have java artifacts that should be staged? > > > > 3. checklist > > incubating in name > > signature and hash fine > > DISCLAIMER is fine > > LICENSE and NOTICE are fine > > No unexpected binary files > > All source have ASF headers > > > > 4. what is /docs/archive for? > > > > > > On Wed, May 19, 2021 at 2:41 PM Adam Binford <adam...@gmail.com> wrote: > > > > > +1 (non-binding) > > > > > > On Wed, May 19, 2021 at 12:58 AM Jia Yu <jiayu198...@gmail.com> wrote: > > > > > > > Hi all, > > > > > > > > This is a call for vote on Apache Sedona 1.0.1-incubating-rc1. Please > > > refer > > > > to the changes listed at the bottom of this email. > > > > > > > > Release notes: > > > > > > > > > > > > > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/docs/download/release-notes.md > > > > > > > > Build instructions: > > > > > > > > > > > > > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/docs/download/compile.md > > > > > > > > GitHub tag: > > > > > > > > > > > > > > https://github.com/apache/incubator-sedona/releases/tag/sedona-1.0.1-incubating-rc1 > > > > > > > > GPG public key to verify the Release: > > > > https://dist.apache.org/repos/dist/dev/incubator/sedona/KEYS > > > > > > > > Source code and binaries: > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/sedona/1.0.1-incubating-rc1/ > > > > > > > > The vote will be open for at least 72 hours or until a majority of at > > > least > > > > 3 +1 PMC votes are cast > > > > > > > > Please vote accordingly: > > > > > > > > [ ] +1 approve > > > > > > > > [ ] +0 no opinion > > > > > > > > [ ] -1 disapprove with the reason > > > > > > > > Checklist for reference (because of DISCLAIMER-WIP, other checklist > > items > > > > are not blockers): > > > > > > > > [ ] Download links are valid. > > > > > > > > [ ] Checksums and PGP signatures are valid. > > > > > > > > [ ] DISCLAIMER is included. > > > > > > > > [ ] Source code artifacts have correct names matching the current > > > release. > > > > > > > > For a detailed checklist please refer to: > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > > > > > > > > ------------ > > > > Changes according to the comments of Justin Mclean on the > > > 1.0.0-incubating > > > > release > > > > Original comment URL: > > > > > > > > > > > > > > https://lists.apache.org/thread.html/r828873cbb2685dcfb0719680f3aac6dbf982720fcd9cd5f69a26ec55%40%3Cgeneral.incubator.apache.org%3E > > > > > > > > 1. There are some test files I think I like to know where they come > > from > > > > e.g. county_small_wkb.tsv and what license the contents are under. > > > > > > > > License for test data has been added to Sedona license > > > > > > > > > > > > > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/LICENSE > > > > > > > > 2. The LICENSE here seems odd why does it have "Copyright (c) > > 2019-2020, > > > > Apache Sedona” in it? > > > > > > > > The issue has been fixed. The license for zeppelin plugin has been > > added > > > to > > > > LICENSE as well. > > > > > > > > > > > > > > https://github.com/apache/incubator-sedona/blob/sedona-1.0.1-incubating-rc1/LICENSE > > > > > > > > 3. Please put instructions on how to build in the release, > instructions > > > can > > > > change over time so pointing to a URL may not be helpful when trying > to > > > > build older versions. > > > > > > > > Build instruction has been added to svn/dist/dev > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/sedona/1.0.1-incubating-rc1/ > > > > > > > > > > > > > -- > > > Adam Binford > > > > > >
