There's a script that can be run manually which closes PRs that have been 'requested' to be closed. I'm not sure of the exact words it looks for but "Do you mind closing this PR?" seems to work. However it does seem to mean that PRs will occasionally get closed as a false positive, so maybe that happened here.
You can use your judgment about whether to reopen, but I tend to think PRs are not meant to be long-lived. They don't go away even when closed, so can always stand as a record of a proposed change or be reopened. But there shouldn't be such a thing as a PR open for months. (In practice, you can see a huge number of dead, stale PRs are left open by people out there anyway) On Thu, Dec 31, 2015 at 3:25 AM, Mridul Muralidharan <mri...@gmail.com> wrote: > I am not sure of others, but I had a PR close from under me where > ongoing discussion was as late as 2 weeks back. > Given this, I assumed it was automated close and not manual ! > > When the change was opened is not a good metric about viability of the > change (particularly when it touches code which is rarely modified; > and so will merge after multiple releases). > > Regards, > Mridul > > On Wed, Dec 30, 2015 at 7:12 PM, Reynold Xin <r...@databricks.com> wrote: >> No there is not. I actually manually closed them to cut down the number of >> open pull requests. Feel free to reopen individual ones. >> >> >> On Wednesday, December 30, 2015, Mridul Muralidharan <mri...@gmail.com> >> wrote: >>> >>> Is there a script running to close "old" PR's ? I was not aware of any >>> discussion about this in dev list. >>> >>> - Mridul >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@spark.apache.org >>> For additional commands, e-mail: dev-h...@spark.apache.org >>> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@spark.apache.org > For additional commands, e-mail: dev-h...@spark.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@spark.apache.org For additional commands, e-mail: dev-h...@spark.apache.org
